Skip to content

DRAFT: port optimizer presets and linked workflow parameters (#250–#251) - #4

Draft
JayceeB1 wants to merge 7 commits into
integration/library-lineage-2026-10-09from
integration/optimizer-presets-2026-10-10
Draft

JayceeB1 wants to merge 7 commits into
integration/library-lineage-2026-10-09from
integration/optimizer-presets-2026-10-10

Conversation

@JayceeB1

@JayceeB1 JayceeB1 commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Scope

Second-layer experimental integration on top of staging PR #3. Sources: upstream #250 and upstream #251, originally contributed by @OmarB97.

lightningpixel#250 — Optimizer presets (adapted to current Python engine)

  • 0.4.3 runs the optimizer through api/services/mesh_ops/processor.py and a shared registry; do not reintroduce the legacy processor.ts.
  • Built-in workflow picker offers Full detail (pass-through, default), 12k, 30k, 60k and 120k targets.
  • Only the workflow adapter treats 1,000,000 as keep original file; direct mesh-operation API stays unchanged.
  • Normalize values from HTML selects (strings) and bound model parameters (numbers), rejecting malformed/out-of-bounds inputs without touching the input mesh.
  • Remove the redundant Library confirmation/footer UI from Replace triangle input and remove redundant Library footer lightningpixel/modly#250.
  • Add 4 Python regression methods.

lightningpixel#251 — Workflow params and Library/viewer synchronization

  • Add paramBindings to the workflow schema and resolve values from the freshest live upstream node params at target execution time.
  • Suppress a redundant Generate question for fully bound extension nodes; dangling/self-referential bindings cannot hide the control.
  • Add conservative parameter-key protection and 7 Node unit tests.
  • Synchronize active animation clip and clip list via appStore, with reset when switching assets.
  • Add Library clip selection matching, active-asset identity and zoom-aware viewport panel placement; add Library-focused regressions.
  • Keep the current 0.4.3 viewer export and point-light code.

Evidence / limitations

  • 5 isolated Python checks of the updated optimizer adapter passed (including missing assets, invalid values, 1M no-op, numeric bindings, unchanged other-op dispatch).
  • 7 isolated Node tests of the exact workflow parameter-binding helper passed on Node 22.
  • All edits confined to this child branch, not main or source PR branches.
  • Not yet run: full combined Python and Node suites, TypeScript checks, lint and Electron build.
  • Native Windows desktop smoke: optimizer output, clip switching, responsive Library popover, and restart persistence.
  • End-to-end multi-node bindings on an actual TRELLIS → optimizer workflow.

See the updated docs/experimental-library-integration-ledger.md.

Do not merge to main or ship an installer based solely on these isolated tests. This is a reviewable port, not a proven release.

…eset with regression tests

Preserves Python mesh-op registry for direct API callers; accepts HTML select strings and bound numeric budgets.
…time

Rebased the core lightningpixel#251 behavior on current runner; safeguard dangling/self bindings and unsafe property keys; add seven Node tests.
…imation and responsive popover

Port lightningpixel#251 UI diff with local shared animation store; preserve 0.4.3 point lights and viewer exporter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant