Skip to content

Extend compat HTTP="0.8, 0.9, 1, 2"#34

Merged
ablaom merged 5 commits into
devfrom
http-2
Jun 25, 2026
Merged

Extend compat HTTP="0.8, 0.9, 1, 2"#34
ablaom merged 5 commits into
devfrom
http-2

Conversation

@ablaom

@ablaom ablaom commented Jun 9, 2026

Copy link
Copy Markdown
Member

I had a go at this but am out of depth. Here are the problems:

  • When using Pkg.test() the pre-compilation of HTTP hangs locally (on Julia 1.12.6). I don't know how to fix this, but a workaround is to run `julia --project=. -e 'using Pkg; Pkg.test(julia_args=["--compiled-modules=existing"])' in the OpenML.jl root directory.

  • Tests fail when I run them line by line. Here's the error I'm getting:

julia> response_test = OpenML.load_Dataset_Description(61)
ERROR: http parse error: unexpected EOF while reading HTTP/1 data
Stacktrace:
  [1] _readline_crlf(reader::HTTP._ConnReader, max_line_bytes::Int64)
    @ HTTP ~/.julia/packages/HTTP/M97zq/src/http_transport.jl:1251
  [2] _read_transport_incoming_response(reader::HTTP._ConnReader, transport::HTTP.Transport, conn::HTTP.Conn, request::HTTP.Request{…}, max_line_bytes::Int64, max_header_bytes::Int64)
    @ HTTP ~/.julia/packages/HTTP/M97zq/src/http_transport.jl:1514
  [3] _read_transport_incoming_response
    @ ~/.julia/packages/HTTP/M97zq/src/http_transport.jl:1514 [inlined]
  [4] _roundtrip_incoming!(transport::HTTP.Transport, address::String, request::HTTP.Request
{HTTP.EmptyBody}, secure::Bool, server_name::String, proxy_config::HTTP.ProxyConfig, attempt
::Int64)                                                                                   
    @ HTTP ~/.julia/packages/HTTP/M97zq/src/http_transport.jl:1702
  [5] _roundtrip_incoming!
    @ ~/.julia/packages/HTTP/M97zq/src/http_transport.jl:1609 [inlined]
  [6] _do_incoming!(trace::Nothing, client::HTTP.Client{…}, address::String, request::HTTP.Request{…}, secure::Bool, server_name::String, protocol::Symbol, redirect_policy::HTTP._RedirectPolicy{…}, retry_controller::HTTP._RetryController{…}, proxy_config::HTTP.ProxyConfig, cookies::Bool, cookiejar::CookieJar)                                                        
    @ HTTP ~/.julia/packages/HTTP/M97zq/src/http_client.jl:746
  [7] request(method::String, url::String, h::Vector{…}, b::Nothing; headers::Vector{…}, body::Nothing, basicauth::Nothing, retry::Bool, retries::Int64, retry_non_idempotent::Bool, retry_if::Nothing, respect_retry_after::Bool, retry_bucket::Bool, status_exception::Bool, redirect::Bool, redirect_limit::Nothing, redirect_method::Nothing, forwardheaders::Bool, proxy::HTTP._UseTransportProxy, cookies::Bool, cookiejar::Nothing, query::Nothing, response_stream::
Nothing, decompress::Nothing, max_decompressed_size::Int64, sse_callback::Nothing, client::Nothing, context::Nothing, connect_timeout::Int64, request_timeout::Int64, response_header_timeout::Int64, read_idle_timeout::Int64, write_idle_timeout::Int64, expect_continue_timeout::
Nothing, readtimeout::Nothing, copyheaders::Nothing, pool::Nothing, canonicalize_headers::Nothing, detect_content_type::Nothing, observelayers::Nothing, retry_delays::Nothing, retry_check::Nothing, sslconfig::Nothing, socket_type_tls::Nothing, logerrors::Nothing, logtag::Nothing, trace::Nothing, verbose::Nothing, require_ssl_verification::Bool, protocol::Symbol)
    @ HTTP ~/.julia/packages/HTTP/M97zq/src/http_client.jl:1843
  [8] request (repeats 2 times)
    @ ~/.julia/packages/HTTP/M97zq/src/http_client.jl:1716 [inlined]
  [9] get(query::String)
    @ OpenML ~/MLJ/OpenML/src/data.jl:14
 [10] load_Dataset_Description(id::Int64)
    @ OpenML ~/MLJ/OpenML/src/data.jl:45
 [11] top-level scope
    @ REPL[6]:1

caused by: http2: unexpected ALPN protocol http/1.1; want h2

HTTP 2 is a complete re-write, but I don't understand what has broken here.

@jbrea Are you able to help out with this?

cc @pebeto

@ablaom ablaom marked this pull request as draft June 9, 2026 00:19
jbrea added 2 commits June 23, 2026 21:20
Set explicit Host header for HTTP.jl v2 compatibility
@jbrea

jbrea commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@ablaom I think this is ready for merging thanks to @pebeto

@ablaom ablaom marked this pull request as ready for review June 25, 2026 21:54
@ablaom ablaom merged commit 62962a7 into dev Jun 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants