Skip to content

try to fix nightly - #9

Open
Roger-luo wants to merge 5 commits into
masterfrom
roger/fix-1.9
Open

try to fix nightly#9
Roger-luo wants to merge 5 commits into
masterfrom
roger/fix-1.9

Conversation

@Roger-luo

Copy link
Copy Markdown
Collaborator

fix #8

@codecov

codecov Bot commented Nov 3, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.86%. Comparing base (2169e5f) to head (30b3400).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/patches.jl 50.00% 2 Missing ⚠️
src/passes.jl 66.66% 1 Missing ⚠️
src/typeinf.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   85.35%   84.86%   -0.50%     
==========================================
  Files           9        9              
  Lines         519      522       +3     
==========================================
  Hits          443      443              
- Misses         76       79       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willtebbutt

Copy link
Copy Markdown

@Roger-luo are you interetsed in re-visiting this PR now that 1.9 has stabilised?

@Roger-luo Roger-luo closed this May 15, 2023
@Roger-luo Roger-luo reopened this May 15, 2023
@Roger-luo

Copy link
Copy Markdown
Collaborator Author

I can take a look but no promise - it depends on how complicated it is to figure out a fix. But I think given how much internal has changed it probably makes more sense to rewrite this package instead of maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not load symbol "jl_typeinf_begin" on nightly

2 participants