Repository navigation
ArgTools: Add FileSpec writer - #44
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 88.54% 89.71% +1.17%
==========================================
Files 1 1
Lines 96 107 +11
==========================================
+ Hits 85 96 +11
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
StefanKarpinski
approved these changes
Jun 8, 2026
| """ | ||
| struct FileSpec | ||
| path::String | ||
| mode::Int |
Member
There was a problem hiding this comment.
Maybe mode should be UInt16?
Add FileSpec as an ArgWrite target that carries a path and file creation mode, allowing callers to specify file-opening options without embedding that policy in downstream packages. Co-authored-by: OpenAI Codex <codex@openai.com>
Keno
force-pushed
the
codex/filespec-argwrite
branch
from
June 8, 2026 21:24
b3a728a to
8a985b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add FileSpec as an ArgWrite target that carries a path and file creation mode. A particular motivation is specifying a file mode for the result of
download.