Repository navigation
Build ARG_READERS/ARG_WRITERS without vcat - #45
Merged
Merged
Conversation
The newline-separated literals lowered to `vcat` of differently typed pairs, which put ~1200 concatenation specializations into the package image. Use a typed, comma-separated literal instead. Package image on Julia 1.14 nightly: 1325 -> 109 code instances, .ji 1694 -> 258 KiB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KristofferC
force-pushed
the
kc/no-vcat-test-tables
branch
from
October 7, 2026 08:32
7c2ee96 to
50f9bbb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 89.71% 88.07% -1.65%
==========================================
Files 1 1
Lines 107 109 +2
==========================================
Hits 96 96
- Misses 11 13 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newline-separated
ARG_READERS/ARG_WRITERSliterals lower tovcatof pairs with distinct closure types. Evaluating them while precompiling puts the concatenation machinery (_ntuple,__cat_offset!,collect, ...) into the package image, for constants only used by test utilities. This uses a typed, comma-separated literal instead; iteration over the tables is unchanged.Package image on Julia 1.14.0-DEV nightly (both versions precompiled locally the same way):
.ji.so