CompatHelper: bump compat for PureUMFPACK in [weakdeps] to 1, (keep existing compat) - #748
Open
github-actions[bot] wants to merge 1 commit into
Conversation
Contributor
Author
Dagger benchmarks:
|
| master | dirty | master / dirty | |
|---|---|---|---|
| array/dagger/N=1024 (block 512)/add (X + X) | 2.98 ± 2 ms | 3.39 ± 1.3 ms | 0.88 ± 0.68 |
| array/dagger/N=1024 (block 512)/alloc (rand) | 2.32 ± 2.1 ms | 2.11 ± 0.7 ms | 1.1 ± 1.1 |
| array/dagger/N=1024 (block 512)/broadcast (X .+ 1) | 2.55 ± 0.89 ms | 2.24 ± 0.65 ms | 1.14 ± 0.52 |
| array/dagger/N=1024 (block 512)/map (sin.(X)) | 6.31 ± 1 ms | 5.93 ± 0.77 ms | 1.06 ± 0.22 |
| array/dagger/N=1024 (block 512)/norm | 1.18 ± 0.11 ms | 2.75 ± 2.5 ms | 0.428 ± 0.39 |
| array/dagger/N=1024 (block 512)/reduce (sum) | 3.11 ± 2.2 ms | 2.18 ± 0.62 ms | 1.43 ± 1.1 |
| array/dagger/N=1024 (block 512)/transpose (permutedims) | 4.85 ± 1.1 ms | 4.21 ± 1.1 ms | 1.15 ± 0.41 |
| array/dagger/N=256 (block 256)/add (X + X) | 1.33 ± 0.52 ms | 0.792 ± 0.019 ms | 1.68 ± 0.66 |
| array/dagger/N=256 (block 256)/alloc (rand) | 0.7 ± 0.039 ms | 0.681 ± 0.052 ms | 1.03 ± 0.097 |
| array/dagger/N=256 (block 256)/broadcast (X .+ 1) | 0.447 ± 0.066 ms | 0.491 ± 0.23 ms | 0.91 ± 0.44 |
| array/dagger/N=256 (block 256)/map (sin.(X)) | 0.968 ± 0.024 ms | 0.97 ± 0.047 ms | 0.998 ± 0.054 |
| array/dagger/N=256 (block 256)/norm | 0.484 ± 0.02 ms | 0.493 ± 0.076 ms | 0.981 ± 0.16 |
| array/dagger/N=256 (block 256)/reduce (sum) | 0.617 ± 0.087 ms | 0.7 ± 1.6 ms | 0.881 ± 2.1 |
| array/dagger/N=256 (block 256)/transpose (permutedims) | 0.857 ± 0.85 ms | 0.799 ± 0.086 ms | 1.07 ± 1.1 |
| linalg/dagger/N=1024 (block 512)/cholesky | 27.1 ± 3 ms | 20.4 ± 4.2 ms | 1.33 ± 0.31 |
| linalg/dagger/N=1024 (block 512)/lu | 0.0425 ± 0.0014 s | 0.044 ± 0.0022 s | 0.967 ± 0.059 |
| linalg/dagger/N=1024 (block 512)/matmul (A*A) | 0.0458 ± 0.0064 s | 0.0487 ± 0.012 s | 0.94 ± 0.26 |
| linalg/dagger/N=1024 (block 512)/matvec (A*x) | 4.38 ± 2.8 ms | 3.86 ± 1.9 ms | 1.13 ± 0.93 |
| linalg/dagger/N=1024 (block 512)/qr | 0.111 ± 0.0027 s | 0.11 ± 0.0042 s | 1 ± 0.045 |
| linalg/dagger/N=1024 (block 512)/solve (A\b via lu) | 0.0531 ± 0.0097 s | 0.0545 ± 0.016 s | 0.974 ± 0.33 |
| linalg/dagger/N=1024 (block 512)/svd | 0.0371 h | 0.0357 h | 1.04 |
| linalg/dagger/N=1024 (block 512)/syrk (A'*A) | 0.0361 ± 0.0016 s | 0.0363 ± 0.0036 s | 0.996 ± 0.11 |
| linalg/dagger/N=256 (block 256)/cholesky | 5.69 ± 4 ms | 2.39 ± 4.1 ms | 2.38 ± 4.4 |
| linalg/dagger/N=256 (block 256)/lu | 4.26 ± 0.9 ms | 3.62 ± 2.2 ms | 1.18 ± 0.76 |
| linalg/dagger/N=256 (block 256)/matmul (A*A) | 2.3 ± 0.32 ms | 2.65 ± 0.59 ms | 0.867 ± 0.23 |
| linalg/dagger/N=256 (block 256)/matvec (A*x) | 0.944 ± 0.025 ms | 1.91 ± 0.2 ms | 0.494 ± 0.054 |
| linalg/dagger/N=256 (block 256)/qr | 5.92 ± 1 ms | 5.68 ± 2.2 ms | 1.04 ± 0.45 |
| linalg/dagger/N=256 (block 256)/solve (A\b via lu) | 11.7 ± 3.5 ms | 13.4 ± 8.7 ms | 0.876 ± 0.63 |
| linalg/dagger/N=256 (block 256)/svd | 0.621 ± 0.01 s | 0.534 ± 0.057 s | 1.16 ± 0.12 |
| linalg/dagger/N=256 (block 256)/syrk (A'*A) | 3.16 ± 0.31 ms | 4.7 ± 2.2 ms | 0.672 ± 0.32 |
| sparse/dagger/N=1024 (block 64)/cg solve (laplacian) | 0.933 ± 0.034 s | 0.92 ± 0.057 s | 1.01 ± 0.073 |
| sparse/dagger/N=1024 (block 64)/spgemm (S*S) | 0.454 ± 0.03 s | 0.487 ± 0.012 s | 0.932 ± 0.066 |
| sparse/dagger/N=1024 (block 64)/spmv (S*x) | 0.0564 ± 0.0046 s | 0.0529 ± 0.0032 s | 1.07 ± 0.11 |
| sparse/dagger/N=256 (block 16)/cg solve (laplacian) | 0.914 ± 0.042 s | 0.926 ± 0.041 s | 0.987 ± 0.062 |
| sparse/dagger/N=256 (block 16)/spgemm (S*S) | 0.481 ± 0.024 s | 0.473 ± 0.018 s | 1.02 ± 0.065 |
| sparse/dagger/N=256 (block 16)/spmv (S*x) | 0.0661 ± 0.0079 s | 0.0635 ± 0.024 s | 1.04 ± 0.41 |
| stencil/dagger/N=1024 (block 512)/alloc (neighbors Wrap) | 7.64 ± 1.1 ms | 6.43 ± 0.6 ms | 1.19 ± 0.21 |
| stencil/dagger/N=1024 (block 512)/assign (const) | 1.05 ± 0.86 ms | 0.912 ± 1.7 ms | 1.15 ± 2.3 |
| stencil/dagger/N=1024 (block 512)/multi-expr | 4.05 ± 0.7 ms | 2.83 ± 1.2 ms | 1.43 ± 0.67 |
| stencil/dagger/N=1024 (block 512)/neighbors (Clamp) | 6 ± 0.18 ms | 5.82 ± 0.29 ms | 1.03 ± 0.06 |
| stencil/dagger/N=1024 (block 512)/neighbors (Pad) | 6.27 ± 1 ms | 6.8 ± 2.5 ms | 0.922 ± 0.38 |
| stencil/dagger/N=1024 (block 512)/neighbors (Reflect) | 6.34 ± 0.81 ms | 5.29 ± 0.14 ms | 1.2 ± 0.16 |
| stencil/dagger/N=1024 (block 512)/neighbors (Wrap) | 6.15 ± 0.94 ms | 6.56 ± 0.34 ms | 0.937 ± 0.15 |
| stencil/dagger/N=1024 (block 512)/update (+) | 1.75 ± 0.41 ms | 1.37 ± 1.7 ms | 1.28 ± 1.7 |
| stencil/dagger/N=256 (block 256)/alloc (neighbors Wrap) | 1.62 ± 0.098 ms | 1.85 ± 0.044 ms | 0.873 ± 0.057 |
| stencil/dagger/N=256 (block 256)/assign (const) | 0.483 ± 0.053 ms | 0.503 ± 0.022 ms | 0.96 ± 0.11 |
| stencil/dagger/N=256 (block 256)/multi-expr | 1.05 ± 0.95 ms | 0.921 ± 0.36 ms | 1.14 ± 1.1 |
| stencil/dagger/N=256 (block 256)/neighbors (Clamp) | 1.64 ± 0.053 ms | 1.57 ± 1.6 ms | 1.04 ± 1.1 |
| stencil/dagger/N=256 (block 256)/neighbors (Pad) | 1.62 ± 0.41 ms | 1.38 ± 0.082 ms | 1.17 ± 0.3 |
| stencil/dagger/N=256 (block 256)/neighbors (Reflect) | 1.62 ± 1.6 ms | 1.38 ± 0.031 ms | 1.17 ± 1.1 |
| stencil/dagger/N=256 (block 256)/neighbors (Wrap) | 1.51 ± 0.14 ms | 1.25 ± 0.01 ms | 1.2 ± 0.11 |
| stencil/dagger/N=256 (block 256)/update (+) | 0.688 ± 0.49 ms | 0.738 ± 0.21 ms | 0.932 ± 0.72 |
| time_to_load | 1.11 ± 0.011 s | 1.11 ± 0.014 s | 1.01 ± 0.016 |
Allocations / memory
| master | dirty | master / dirty | |
|---|---|---|---|
| array/dagger/N=1024 (block 512)/add (X + X) | 5.56 k allocs: 8.22 MB | 5.55 k allocs: 8.22 MB | 1 |
| array/dagger/N=1024 (block 512)/alloc (rand) | 2.75 k allocs: 8.09 MB | 2.74 k allocs: 8.09 MB | 1 |
| array/dagger/N=1024 (block 512)/broadcast (X .+ 1) | 2.41 k allocs: 8.08 MB | 2.38 k allocs: 8.08 MB | 1 |
| array/dagger/N=1024 (block 512)/map (sin.(X)) | 2.1 k allocs: 8.07 MB | 2.1 k allocs: 8.07 MB | 1 |
| array/dagger/N=1024 (block 512)/norm | 2.71 k allocs: 0.09 MB | 2.64 k allocs: 0.088 MB | 1.02 |
| array/dagger/N=1024 (block 512)/reduce (sum) | 4.57 k allocs: 0.157 MB | 3.69 k allocs: 0.126 MB | 1.25 |
| array/dagger/N=1024 (block 512)/transpose (permutedims) | 3.31 k allocs: 8.14 MB | 3.32 k allocs: 8.14 MB | 1 |
| array/dagger/N=256 (block 256)/add (X + X) | 1.73 k allocs: 0.575 MB | 1.73 k allocs: 0.575 MB | 1 |
| array/dagger/N=256 (block 256)/alloc (rand) | 0.754 k allocs: 0.526 MB | 0.754 k allocs: 0.526 MB | 1 |
| array/dagger/N=256 (block 256)/broadcast (X .+ 1) | 0.646 k allocs: 0.522 MB | 0.651 k allocs: 0.522 MB | 1 |
| array/dagger/N=256 (block 256)/map (sin.(X)) | 0.563 k allocs: 0.519 MB | 0.569 k allocs: 0.519 MB | 1 |
| array/dagger/N=256 (block 256)/norm | 0.715 k allocs: 24.6 kB | 0.715 k allocs: 24.6 kB | 1 |
| array/dagger/N=256 (block 256)/reduce (sum) | 0.816 k allocs: 30.5 kB | 0.816 k allocs: 30.5 kB | 1 |
| array/dagger/N=256 (block 256)/transpose (permutedims) | 1.11 k allocs: 0.551 MB | 1.11 k allocs: 0.551 MB | 1 |
| linalg/dagger/N=1024 (block 512)/cholesky | 7.8 k allocs: 10.3 MB | 7.82 k allocs: 10.3 MB | 1 |
| linalg/dagger/N=1024 (block 512)/lu | 15.7 k allocs: 14.6 MB | 15.7 k allocs: 14.6 MB | 1 |
| linalg/dagger/N=1024 (block 512)/matmul (A*A) | 7.69 k allocs: 8.28 MB | 7.71 k allocs: 8.29 MB | 1 |
| linalg/dagger/N=1024 (block 512)/matvec (A*x) | 6.23 k allocs: 0.248 MB | 6.44 k allocs: 0.259 MB | 0.957 |
| linalg/dagger/N=1024 (block 512)/qr | 10.8 k allocs: 9.57 MB | 11.6 k allocs: 9.6 MB | 0.997 |
| linalg/dagger/N=1024 (block 512)/solve (A\b via lu) | 29.4 k allocs: 15.2 MB | 29.8 k allocs: 15.2 MB | 0.999 |
| linalg/dagger/N=1024 (block 512)/svd | 0.0495 M allocs: 0.197 GB | 0.0503 M allocs: 0.198 GB | 1 |
| linalg/dagger/N=1024 (block 512)/syrk (A'*A) | 9.08 k allocs: 20.4 MB | 9.11 k allocs: 20.4 MB | 1 |
| linalg/dagger/N=256 (block 256)/cholesky | 3.03 k allocs: 0.634 MB | 3.04 k allocs: 0.634 MB | 1 |
| linalg/dagger/N=256 (block 256)/lu | 5.43 k allocs: 1.24 MB | 5.38 k allocs: 1.24 MB | 1 |
| linalg/dagger/N=256 (block 256)/matmul (A*A) | 1.94 k allocs: 0.582 MB | 1.93 k allocs: 0.582 MB | 1 |
| linalg/dagger/N=256 (block 256)/matvec (A*x) | 2.37 k allocs: 0.1 MB | 2.34 k allocs: 0.099 MB | 1.01 |
| linalg/dagger/N=256 (block 256)/qr | 3.45 k allocs: 0.779 MB | 3.46 k allocs: 0.78 MB | 0.999 |
| linalg/dagger/N=256 (block 256)/solve (A\b via lu) | 11.9 k allocs: 1.53 MB | 12 k allocs: 1.53 MB | 0.997 |
| linalg/dagger/N=256 (block 256)/svd | 15.5 k allocs: 6.71 MB | 15.5 k allocs: 6.71 MB | 1 |
| linalg/dagger/N=256 (block 256)/syrk (A'*A) | 3.07 k allocs: 2.14 MB | 3.07 k allocs: 2.14 MB | 1 |
| sparse/dagger/N=1024 (block 64)/cg solve (laplacian) | 2.95 M allocs: 0.11 GB | 2.96 M allocs: 0.11 GB | 1 |
| sparse/dagger/N=1024 (block 64)/spgemm (S*S) | 2.9 M allocs: 0.142 GB | 3.18 M allocs: 0.151 GB | 0.941 |
| sparse/dagger/N=1024 (block 64)/spmv (S*x) | 0.183 M allocs: 6.97 MB | 0.16 M allocs: 6.18 MB | 1.13 |
| sparse/dagger/N=256 (block 16)/cg solve (laplacian) | 2.9 M allocs: 0.107 GB | 2.92 M allocs: 0.108 GB | 0.994 |
| sparse/dagger/N=256 (block 16)/spgemm (S*S) | 2.87 M allocs: 0.104 GB | 3.18 M allocs: 0.114 GB | 0.917 |
| sparse/dagger/N=256 (block 16)/spmv (S*x) | 0.2 M allocs: 7.54 MB | 0.185 M allocs: 7.03 MB | 1.07 |
| stencil/dagger/N=1024 (block 512)/alloc (neighbors Wrap) | 4.77 k allocs: 8.2 MB | 4.82 k allocs: 8.2 MB | 1 |
| stencil/dagger/N=1024 (block 512)/assign (const) | 2.18 k allocs: 0.0952 MB | 2.15 k allocs: 0.0941 MB | 1.01 |
| stencil/dagger/N=1024 (block 512)/multi-expr | 4.81 k allocs: 0.212 MB | 4.79 k allocs: 0.211 MB | 1 |
| stencil/dagger/N=1024 (block 512)/neighbors (Clamp) | 3.82 k allocs: 0.232 MB | 3.82 k allocs: 0.232 MB | 1 |
| stencil/dagger/N=1024 (block 512)/neighbors (Pad) | 3.7 k allocs: 0.229 MB | 3.69 k allocs: 0.228 MB | 1 |
| stencil/dagger/N=1024 (block 512)/neighbors (Reflect) | 3.82 k allocs: 0.264 MB | 3.81 k allocs: 0.264 MB | 1 |
| stencil/dagger/N=1024 (block 512)/neighbors (Wrap) | 3.65 k allocs: 0.168 MB | 3.64 k allocs: 0.167 MB | 1 |
| stencil/dagger/N=1024 (block 512)/update (+) | 2.67 k allocs: 0.118 MB | 2.6 k allocs: 0.116 MB | 1.02 |
| stencil/dagger/N=256 (block 256)/alloc (neighbors Wrap) | 1.56 k allocs: 0.574 MB | 1.56 k allocs: 0.575 MB | 0.999 |
| stencil/dagger/N=256 (block 256)/assign (const) | 0.8 k allocs: 0.0406 MB | 0.811 k allocs: 0.041 MB | 0.991 |
| stencil/dagger/N=256 (block 256)/multi-expr | 1.73 k allocs: 0.0873 MB | 1.73 k allocs: 0.0873 MB | 1 |
| stencil/dagger/N=256 (block 256)/neighbors (Clamp) | 1.26 k allocs: 0.0718 MB | 1.26 k allocs: 0.0721 MB | 0.996 |
| stencil/dagger/N=256 (block 256)/neighbors (Pad) | 1.21 k allocs: 0.07 MB | 1.21 k allocs: 0.0703 MB | 0.995 |
| stencil/dagger/N=256 (block 256)/neighbors (Reflect) | 1.27 k allocs: 0.0796 MB | 1.26 k allocs: 0.0793 MB | 1 |
| stencil/dagger/N=256 (block 256)/neighbors (Wrap) | 1.25 k allocs: 0.0645 MB | 1.21 k allocs: 0.0633 MB | 1.02 |
| stencil/dagger/N=256 (block 256)/update (+) | 0.924 k allocs: 0.0463 MB | 0.924 k allocs: 0.0463 MB | 1 |
| time_to_load | 0.147 k allocs: 10.8 kB | 0.147 k allocs: 10.8 kB | 1 |
Plots
⚠️ Regressions (time > 25.0% and outside the reported ±spread; allocs/memory > 25.0%)
linalg/dagger/N=256 (block 256)/matvec (A*x)(time): +102.3%
Improvements
array/dagger/N=256 (block 256)/add (X + X)(time): -40.5%
Within noise (5 metric(s) past threshold but inside the ±spread; not counted)
array/dagger/N=1024 (block 512)/norm(time): 133.7%linalg/dagger/N=256 (block 256)/syrk (A'*A)(time): 48.8%stencil/dagger/N=1024 (block 512)/multi-expr(time): -30.1%array/dagger/N=1024 (block 512)/reduce (sum)(time): -30.1%linalg/dagger/N=256 (block 256)/cholesky(time): -58.1%
Full results and plots (download the benchmark-results artifact).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
PureUMFPACKpackage from0.1to0.1, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.