Skip to content

[KDM-TEST-FIX-325] fix: treat succeeded pods as healthy - #325

Open
Ch4nnXDev wants to merge 1 commit into
KDM-cli:mainfrom
Ch4nnXDev:fix/health-dashboard-succeeded-pods
Open

Ch4nnXDev wants to merge 1 commit into
KDM-cli:mainfrom
Ch4nnXDev:fix/health-dashboard-succeeded-pods

Conversation

@Ch4nnXDev

Copy link
Copy Markdown

Fixed the health dashboard incorrectly showing completed (Succeeded) pods as failed.

Treat Succeeded pods as healthy.

Added a regression test for succeeded pods.

Fixes #262

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: QUIET

Plan: Advanced

Run ID: 768ebf4d-b176-4f0a-b412-fe2d99762092

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

Parsing errors (2)
Validation error: Invalid input: expected string, received undefined at "reviews.path_instructions[3].path"; Invalid input: expected string, received undefined at "reviews.path_instructions[3].instructions"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix: treat succeeded pods as healthy [KDM-TEST-FIX-325] fix: treat succeeded pods as healthy Sep 24, 2026

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@utkarsh232005

Copy link
Copy Markdown
Member

Thanks for the contribution, @Ch4nnXDev! Could you please leave a comment on #262 so I can assign the issue to you? Once that's done, we can proceed with merging this PR smoothly.

@utkarsh232005

Copy link
Copy Markdown
Member

LGTM!!!

@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Ch4nnXDev

Copy link
Copy Markdown
Author

Hi Mr. @utkarsh232005, I’ve implemented the fix for this issue in PR # and Added the Comment Now, Happy to take ownership of #262.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: HealthDashboard marks completed Succeeded batch pods as failed with red ✖ and 'UnknownError'

2 participants