Conversation
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSVC TLS probe currently compiles
extern __thread int x;without the__thread=__declspec(thread)definition accumulated inGK_COPTIONS. The probe fails with C2054/C2085, soconf/gkbuild.cmakeappends an empty-D__thread=even when the linked GKlib uses real TLS.Make the probe self-contained for MSVC and define/read a TLS variable so that the test checks actual TLS access instead of an unused declaration. Other compilers retain
__thread.The same issue has existing METIS proposals: KarypisLab/METIS#74 and KarypisLab/METIS#114. This PR fixes the matching probe in ParMETIS.
Validation on Windows x64/MSVC with MS-MPI:
HAVE_THREADLOCALSTORAGE=FALSE, final flags contain both-D__thread=__declspec(thread)and-D__thread=.HAVE_THREADLOCALSTORAGE=TRUE, no empty override.ParMETIS_V3_PartKway: original Release/MPI2 crashes atMETIS_PartGraphKway->setjmp; patched Debug/Release with MPI2/MPI4 pass. A repeated-call regression also verifies every partition ID, nonempty coverage, and the reported edge cut against the gathered partition.The runtime crash is specifically caused by METIS reading GKlib TLS signal buffers as ordinary globals. Both projects contain the defective detection; this change makes ParMETIS agree with GKlib as well. No partitioning algorithm changes. Non-Windows builds were not run.