refactor: builder.go TLS/ConfigMap concern 추가 분리 (역할분리 2차)#384
Merged
Conversation
builder.go(2017→1837 LOC)에서 TLS + ConfigMap 빌더를 응집 파일로 추가 분리 (순수 재배치, 로직/시그니처 변경 0). hpa/backup/policy(1차, #383)에 이어 누적 builder.go 2705→1837 LOC (-32%, 6 concern 파일). - builder_tls.go (121 LOC): PEM merge init container + TLS volume/mount/args. - builder_configmap.go ( 89 LOC): MongoDB/Custom/cfg/shard scripts ConfigMap. 공유 const(MongoTLSMountPath/PEMPath, scriptReadiness 등) + script helper 는 builder.go 잔류(같은 package 참조). 검증: gofmt 0 / go build OK / vet clean / golangci-lint 0 issues / resources test ok / KUBEBUILDER_ASSETS=… controller envtest 전체 suite ok. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
builder_tls.go 분리 후 "tls-server"/"tls-server-pem" 볼륨명 리터럴이 각 3회로 goconst threshold 도달 → 파일-로컬 상수 2개로 통일 (PEM init / server mount 공용). 검증: gofmt 0 / go build OK / vet clean / golangci-lint 0 issues / resources test ok. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
builder.go에서 TLS + ConfigMap 빌더를 응집 파일로 추가 분리 — 순수 재배치(로직/시그니처 변경 0). hpa/backup/policy(#383)에 이어 누적 builder.go 2705 → 1837 LOC (-32%, 6 concern 파일).builder_tls.go(121): PEM merge init + TLS volume/mount/argsbuilder_configmap.go(89): MongoDB/Custom/cfg/shard scripts ConfigMap공유 const + script helper 는 builder.go 잔류(같은 package). 파일 이동은 goconst package-wide 카운트 불변 → 신규 lint 0.
검증
🤖 Generated with Claude Code