Bake PHOLD into the Docker image - #149
Merged
Merged
Conversation
waxlamp
previously approved these changes
Aug 26, 2026
waxlamp
left a comment
waxlamp
left a comment
Collaborator
There was a problem hiding this comment.
I was able to build this branch (with the help of the changes in the container-rev-matching branch) and the changes make sense to me.
waxlamp
approved these changes
Aug 28, 2026
marySalvi
approved these changes
Sep 3, 2026
marySalvi
left a comment
marySalvi
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, built and ran PHOLD locally successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_ingest_output_filesnow marks the runFAILEDwhen zero expected output files are found, instead of silently completing with no data.PHOLDagainstOpenMPI; the final image copies just the compiled binary to/opt/ross/phold.${ROSS_PATH:-../ross}bind mountsROSS_PATH