perf(control): cache upscaled cond_hint across sliding context steps - #259
Open
neverbiasu wants to merge 1 commit into
Open
perf(control): cache upscaled cond_hint across sliding context steps#259neverbiasu wants to merge 1 commit into
neverbiasu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cond_hinttensor inControlNetAdvancedsub_idxsdirectly from cached tensor during sliding context stepscleanup_advanced()Fixes the TODO in
adv_control/control.py(L66).Previously,
sliding_get_controlre-rancommon_upscale(tensor interpolation) on every single sampling step wheneversub_idxswas present. For video or AnimateDiff workflows, this meant tens of redundant upscale calls on identical input tensors.This PR caches the full upscaled tensor in
self._cached_cond_hint. During sliding context steps,self.cond_hintis sliced directly via_cached_cond_hint[sub_idxs].Cache invalidation handles changes to
cond_hint_originalidentity, batch size, spatial latent size, device, or dtype.Verification
python -m unittest discover -s tests(16/16 passed).diff = 0.0).