fix: isolate workload discovery failures by group version#164
Open
loosekite wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The controller currently calls
ServerGroupsAndResourceswhile deciding whether to register each workload watcher. If any unrelated aggregated API group fails discovery (for example, an empty response frommetrics/v1alpha1), discovery returns a partial-result error and the controller skips otherwise-supported workload watchers such as CollaSet. The webhook can still pause the workload, but the missing watcher prevents rollout reconciliation from advancing it.The memory discovery cache already stores results per GroupVersion. Reading the target GroupVersion result isolates unrelated failures without weakening the safety boundary for the target workload type.
Related issue
Fixes #163
Verification
go test ./pkg/controllers/rollout -run Discovery -count=1go test -race ./pkg/controllers/rollout -run Discovery -count=1go test ./pkg/controllers/rollout -run 'Test(SingleClusterDiscovery|MultiClusterDiscovery|construct|resolve)' -count=1go vet ./pkg/controllers/rolloutgit diff --check