update key early in the process - #9
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a command to download and save the ROS archive keyring early in the Docker build process.
- Introduces a
curlstep to fetch the ROS GPG key before package operations - Keeps subsequent
apt-get update && apt-get upgradeintact
Comments suppressed due to low confidence (1)
Dockerfile:8
- Ensure that
curl(and any required SSL certificates) is installed before this RUN step; consider combining it with theapt-get installcommand to avoid missing dependencies and extra layers.
RUN curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros-archive-keyring.gpg
|
|
||
| ENV DEBIAN_FRONTEND=noninteractive | ||
|
|
||
| RUN curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros-archive-keyring.gpg |
There was a problem hiding this comment.
Storing GPG keys in /usr/share/keyrings is fine, but Debian guidelines recommend /etc/apt/keyrings; consider moving the key to /etc/apt/keyrings/ros-archive-keyring.gpg for consistency.
Suggested change
| RUN curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros-archive-keyring.gpg | |
| RUN mkdir -p /etc/apt/keyrings && curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /etc/apt/keyrings/ros-archive-keyring.gpg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8
This pull request introduces a minor change to the
Dockerfile. It adds a command to download and save the ROS archive keyring, which is likely a prerequisite for working with ROS packages.