Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a memory-mapped
CCDDatacurrently copies its uncertainty array into two temporary files: once in the constructor and again in the uncertainty setter. Only the second mapping is kept as the uncertainty array, so every construction does an unnecessary full-image allocation and copy.The original
CCDData.__init__indata.pycalls_init_array()before assigning the result toself.uncertainty:That assignment invokes the
uncertaintysetter, which calls_init_array()again on the already mapped array:With memory mapping enabled, each
_init_array()call creates a temporary file and copies the array into a new memory map. The constructor therefore creates two copies of the same uncertainty image.Pass the original array directly to the setter:
The setter still validates the shape and creates the memory map, now only once. This removes one temporary file and one full-image copy per
CCDDataconstruction while preserving the uncertainty values.