Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MosaicCreator rebuilds the science, mask, and uncertainty arrays even when a single component already matches the output geometry. For large QHY frames, this adds unnecessary memory copying and temporary-file allocation.
This PR adds a shortcut for single-component images that already match the output geometry. It reuses existing arrays while keeping the same header updates, uncertainty precision, and memory-map behavior in later stages.
The shortcut is used for inputs with native float64 science data, uint8 masks, and writable, contiguous arrays. All other inputs use the existing mosaic code.
Validation