Refuse header-ephemeris photometry on sidereally tracked frames. - #134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EphemerisHeadersnow refuses frames with fits header keywordSRCTYPE = EXTRASOLAR, before anypixels are read, and names the operation that can measure them instead.
Why
SRCTYPErecords how the observation was scheduled, and so how the mount tracked.On a solar-system object the scheduler follows an ephemeris and
CAT-RA/CAT-DECcarries the target's own position; on
EXTRASOLARthose coordinates record where the telescopewas pointed.
Testing
Two tests added:
EXTRASOLARframes are refused,MINORPLANETframes still producea light curve. Full suite passes. Verified end to end on real data — the 3I/ATLAS rp
frames are refused, Kleopatra still returns 13 rows.