Repository navigation
refactor: remove dead IPC channels, markup and a volume shim - #362
Merged
Merged
Conversation
Both were exposed through the preload and handled in main, but nothing in the renderer calls them: get-settings-path lost its caller in the Settings redesign (#334), and diag-log-reset never had one. settings.example.json said "Settings shows the exact path", which stopped being true with #334. It now points at the log's startup line, which prints the logs folder that settings.json sits next to. Closes #356 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- #bottom-logo: single view's bottom logo was removed on 2026-01-16 (e6d918b); since then setLayout hid it in both layouts. - .input-label: the element left index.html in 77acd52 (2025-12-30), so both lookups were null and the guarded writes that named the input in it never ran. The test fixture still created it; it no longer does. - renderDropdownVolumeControls(): a one-line shim for renderDropdownInputLists(), whose only caller ran straight after a call to that function, so the pickers rendered twice at startup. No behaviour change. Closes #357 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes dead code found while writing the ADRs in #346. Nothing in the app behaves differently.
#356: two unused IPC channels
get-settings-path: its renderer caller went in the Settings redesign (feat: lay the input controls over the wall and rebuild Settings #334).diag-log-reset: no caller anywhere in git history.Both are removed from
src/main/index.jsandsrc/preload/index.js.settings.example.jsonclaimed that "Settings shows the exact path". That stopped being true with #334. The comment now points at the log's startup line, which prints thelogsfolder thatsettings.jsonsits next to.I didn't write the folder name in. Electron's
userDataname is unclear: there's no top-levelproductName, so Electron would useinput-viewer, but electron-builder may setproductNamewhen it packages the app. labs-videowall-config reports%APPDATA%\input-viewer\on the wall.#357: dead markup and a shim
#bottom-logo(markup, CSS and the element lookup). Single view's bottom logo was removed on 2026-01-16 (e6d918b); since thensetLayouthid it in both layouts..input-label(CSS, the two lookups and the two guarded writes). The element leftindex.htmlin 77acd52 (2025-12-30), so both lookups werenulland the writes never ran. This is wider than the issue listed: the writes instartVideoStream, for mock and real inputs, were dead too.test/helpers/renderer-dom.js) still created.input-labelnodes. Its comment said they "mirror index.html", which hasn't been true since then. Both are fixed.renderDropdownVolumeControls(): a one-line shim forrenderDropdownInputLists(). Its only caller ran straight after a call to that same function, so the pickers rendered twice at startup.Test plan
npm test: 58 files, 937 tests passnpm run lintcleannpm run buildsucceedsgit grepfinds no remaining references to any removed namerenderer.jsagainst a fixture derived from its owngetElementByIdcalls, so a stale lookup would have failed there.🤖 Generated with Claude Code