fix: convert timestamp to date math#695
Merged
Merged
Conversation
adsharma
force-pushed
the
fix/timestamp-interval-conversion
branch
from
July 18, 2026 15:10
47500fb to
ab9c795
Compare
…ys conversion Interval::getMicro and PyQueryResult interval-to-timedelta now use days = years * 365 + months * 30 + days instead of days = months * 30 + days This gives 365 days per whole year instead of 360, matching the engine's DAYS_PER_YEAR constant (365) vs DAYS_PER_MONTH (30).
adsharma
force-pushed
the
fix/timestamp-interval-conversion
branch
from
July 18, 2026 15:23
ab9c795 to
fcda354
Compare
adsharma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #694
Interval::getMicro uses DAYS_PER_YEAR (365) for whole years instead of DAYS_PER_MONTH * 12 (360), matching the documented constants.