[lua] Fix CoP 5-2 and Container:isVarBitsSet bug

[Nobutadas]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes CoP 5-2 as well as a bug in Container:isVarBitsSet.

CoP 5-2:

• You could enter Spire of Vahzl if you never fought an NM (Status == 0). This fixes that.
• You could trigger an event if the NM was alive. This fixes that.
• Container:isVarBitsSet should be doing an exact match. Fixing this function corrects quests/bastok/Stamp_hunt.lua and quests/ahtUrhgan/Arts_and_Crafts.lua. CoP 5-2 was doing an odd check later on to correct for the bug in isVarBitsSet.

Steps to test these changes

Run through CoP 5-2 as well as Stamp Hunt and Arts and Crafts.

[WinterSolstice8]

Container:isVarBitsSet is OR'ing the bits instead of AND'ing the bits.

no, it is ANDing the bits, its just that any non-zero bit from any AND sets a non-zero value and the result is based on a partial match of bits (~= 0) and not an exact match (== sum)

[Nobutadas]

Container:isVarBitsSet is OR'ing the bits instead of AND'ing the bits.

no, it is ANDing the bits, its just that any non-zero bit from any AND sets a non-zero value and the result is based on a partial match of bits (~= 0) and not an exact match (== sum)

The final check is effectively an OR, right? The for loop ANDs all the bits, but then the function does final check incorrectly? Or am I just misunderstanding bit math?

Edit: It's probably my phrasing is wrong but the fix is right?

[Nobutadas]

Ignore my previous comment. I see it now based on what Winter said. I completely brainfarted and my fix was luckily correct.

I for some reason thought the for loop was ORing the variable. I don't know why I thought this as the variable isn't anywhere except in bit.band.

I'll go ahead and update the PR description.

[Nobutadas]

I was correcting CoP 5-2 when I realized the code had a weird work-around for the isVarBitsSet bug. I noticed I needed to combine the CoP 5-2 fix with this. I checked the other 2 quests and they are coded correctly.

I've updated the PR name and description.

[github-actions]

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

[Nobutadas]

Please let me know what you'd like me to change.

Right now on LSB, you don't have to kill any of the 3 NMs to trigger the door events for CoP 5-2