Skip to content

Core, DB: Introduce xi_unit_test, various improvements to db layer - #11076

Open
zach2good wants to merge 22 commits into
basefrom
db_layer_improvements
Open

Core, DB: Introduce xi_unit_test, various improvements to db layer#11076
zach2good wants to merge 22 commits into
basefrom
db_layer_improvements

Conversation

@zach2good

@zach2good zach2good commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Review commit-by-commit, if you so please.

  • Expands handled types
  • Expands db API
  • Adds compile-time checking of queries
  • Reduces allocations for all things db related
  • Even more security around transactions
  • Removes the shared_ptr hack for blob handling inside db layer
  • Lots of unit tests
  • Moves C++-only unit tests into it's own exe
  • Run that exe alongside the build, so we can fail sooner if something is majorly wrong (these run fast anyway)

zach2good added 22 commits August 9, 2026 16:22
@zach2good
DB: Add 64-bit and NULL parameter binding
f5e4d44
@zach2good
DB: Classify queries once, at statement-prepare time
91079ea
@zach2good
DB: Refuse the rest of a transaction severed by a reconnect
a20ea73 
Not retrying the failed statement still leaves the statements after it to run, one by one, on a fresh auto-committing connection.
@zach2good
DB: Resolve column names to indices once per access
394a766
@zach2good
DB: Report unknown result-set columns instead of reading zeros
a7a4893
@zach2good
DB: Store result-set cells in one flat grid
e0daca9
@zach2good
DB: Remove the now-unused autocommit helpers
ce0b2d8
@zach2good
DB: Remove escapeString
8b9638f
@zach2good
DB: Add tryGet<T> and range-based row iteration
3a5ebce
@zach2good
DB: Bind IN (...) lists through placeholders and vector params
8c84a64
@zach2good
DB: Tidy connection and thread lifecycle
d92167c
@zach2good
DB: Add unit tests for the database layer
f00fb20
@zach2good
DB: Validate query strings at compile time
14e0341
@zach2good
DB: Use std::to_underlying for result-set type logging
a84b589
@zach2good
DB: Bind blob parameters by value
3b10a8a
@zach2good
DB: Audit comments across the database layer
82d7479
@zach2good
DB: Make a nested transaction join the one already open
68a9deb 
MySQL has no nested transactions: a second START TRANSACTION commits the outer one, losing its atomicity exactly where the inner call meant to protect it.
@zach2good
DB: Tell bulk callers when a NULL is what failed
41b781e
@zach2good
Build: Move the C++ unit tests into their own xi_unit_test binary
36f9b52 
xi_test boots a server and talks to a live database to run the Lua suite; the Catch2 tests need neither, and rode along at the cost of a ten-minute build and a nine-minute run.
@zach2good
DB: Fail the whole transaction when a statement inside it fails
a5662b8 
Carrying on past a failed statement means the COMMIT keeps every statement around the one that failed, which is the opposite of what the caller asked for.
@zach2good
CI: Build and run xi_unit_test
935d922 
The C++ unit tests used to ride along inside xi_test's startup; splitting them into their own binary took them out of CI until something ran it.
@zach2good
CI: Run xi_unit_test in the build workflow
7ad6c8f 
The tests need nothing the build job does not already have, so every configuration in the matrix can gate on them instead of waiting for the test workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zach2good