Skip to content

[lua] Self Destruct chance - #11111

Open
ThrisStraizo wants to merge 1 commit into
LandSandBoat:basefrom
ThrisStraizo:explodoromo
Open

[lua] Self Destruct chance#11111
ThrisStraizo wants to merge 1 commit into
LandSandBoat:basefrom
ThrisStraizo:explodoromo

Conversation

@ThrisStraizo

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR adjusts the chance for regular bombs to explode to around 25%.

I ultimately testing only letting bombs tp above 25%, under 25%, and all the time, and they all looked about the same.
Ultimately the chance was between 25-30%, ending with 171 berserks and 65 self destructs.

I have set the chance to return at 66%, and because of how math works, that ultimately means they will choose self destruct around 25% of the time.

I removed the HP requirement from grow bombs as I know that's bullshit from testing, and removed the NM blocker as that is already handled in the grow bomb mixin.

https://www.dropbox.com/scl/fo/z650rc7kepgjz4ui89obp/APBJpLrSukfyqy-1j14GgnQ?rlkey=2hr7tfc928aei6wvu5c1bvobx&st=tx1grsco&dl=0

Steps to test these changes

!tp 3000 some bombs.

return 1
else
return 0
end

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a fan. Why not have a family mixing for their skill weights, so we dont have a 34% that is actually somehow a 25%

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this to reflect the return rate needed to match Frank's PR fix to how mobs use TP skills.

This PR adjusts the chance for regular bombs to explode to around 25%.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants