Skip to content

[lua] A Moral Manifest? Bug Fixes - #11153

Draft
KiplingFFXI wants to merge 1 commit into
LandSandBoat:basefrom
KiplingFFXI:A-Moral-Manifest-Fixes
Draft

[lua] A Moral Manifest? Bug Fixes#11153
KiplingFFXI wants to merge 1 commit into
LandSandBoat:basefrom
KiplingFFXI:A-Moral-Manifest-Fixes

Conversation

@KiplingFFXI

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR fixes multiple bugs with the quest A Moral Manifest? - Ideally this quest is a prime candidate for IF conversion, but no captures are publicly hosted. I can come back and fix it at a later date when I get a capture. As is, these bugs were important enough to be fixed now:

  • Ponono no longer lets you keep all your items and gil after trading them.
  • Completing the quest no longer locks you out of Ponono as the Clothcraft guild master.
  • The Stone Lid no longer takes every item in the trade window. Only the Yagudo Headgear is accepted, and anything traded with it is returned.
  • The Stone Lid no longer destroys the Yagudo Headgear when your inventory is full. You get an inventory is full message instead.
  • Popping the Yagudo Avatar no longer throws a script error. Left a TODO for when a capture clears this up to delete the error at this time.
  • Hardcoded item IDs are swapped for their enums, and the leftover wait timer is cleared when the quest completes.

Steps to test these changes

Do the quest. See the above are all fixed and you can complete it.

@KiplingFFXI
KiplingFFXI force-pushed the A-Moral-Manifest-Fixes branch from 9a34aad to 7d9584d Compare August 16, 2026 11:04
@KiplingFFXI
KiplingFFXI marked this pull request as ready for review August 16, 2026 11:06

@zach2good zach2good left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanted to do a really good job here: You could add a test for this, so that when this gets rewritten there's something to test it against

@KiplingFFXI

Copy link
Copy Markdown
Contributor Author

If you wanted to do a really good job here: You could add a test for this, so that when this gets rewritten there's something to test it against

Ok I will do that, thank you. Will throw it into draft for now.

@KiplingFFXI
KiplingFFXI marked this pull request as draft August 16, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants