[lua] A Moral Manifest? Bug Fixes - #11153
Draft
KiplingFFXI wants to merge 1 commit into
Draft
Conversation
KiplingFFXI
force-pushed
the
A-Moral-Manifest-Fixes
branch
from
August 16, 2026 11:04
9a34aad to
7d9584d
Compare
KiplingFFXI
marked this pull request as ready for review
August 16, 2026 11:06
zach2good
reviewed
Aug 16, 2026
zach2good
left a comment
Contributor
There was a problem hiding this comment.
If you wanted to do a really good job here: You could add a test for this, so that when this gets rewritten there's something to test it against
Contributor
Author
Ok I will do that, thank you. Will throw it into draft for now. |
KiplingFFXI
marked this pull request as draft
August 16, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR fixes multiple bugs with the quest A Moral Manifest? - Ideally this quest is a prime candidate for IF conversion, but no captures are publicly hosted. I can come back and fix it at a later date when I get a capture. As is, these bugs were important enough to be fixed now:
Steps to test these changes
Do the quest. See the above are all fixed and you can complete it.