Center window at startup, use LoadLibraryEx over LoadLibrary & improve how the launcher bootstraps the game.#6
Open
Aetopia wants to merge 5 commits into
Open
Center window at startup, use LoadLibraryEx over LoadLibrary & improve how the launcher bootstraps the game.#6Aetopia wants to merge 5 commits into
Aetopia wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds/changes the following:
LoadLibraryExoverLoadLibrarywhich addresses: Prefer LoadLibraryEx with DONT_RESOLVE_DLL_REFERENCES to avoid calling DllMain(). #5The main focus of this PR is improve how the launcher bootstraps the game.
Currently the launcher uses the AUMID of the game to launch it.
This approach is 'bad' due to the fact, it invokes
gamelaunchhelper.exeis a proxy forMinecraft.Windows.exe.gamelaunchhelper.exe.The new approach involves directly invoking
Minecraft.Windows.exeitself usingpowershell.exe&Invoke-CommandInDesktopPackage.gamelaunchhelper.exefrom the picture since it is bypassed.Current approach:
Legacy.-.Launch.Logic.mp4
New approach:
New.-.Launch.Logic.mp4