fix(crypto): accept a string algorithm in CryptoEngine.digest - #94
Merged
Merged
Conversation
Contributor
|
@beaulac is attempting to deploy a commit to the mythie's projects Team on Vercel. A member of the Team first needs to authorize it. |
beaulac
force-pushed
the
fix/digest-alg-string
branch
from
September 14, 2026 13:53
a09c3ce to
65ca929
Compare
Mythie
approved these changes
Sep 16, 2026
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CryptoEngine.digestbase method takes SubtleCrypto'sAlgorithmIdentifier=string | { name: string }, this makes the CryptoEngine's override consistent with this signature. TypeScript unfortunately does not catch this because it checks method parameters bivariantly even with strict on.pkijs passes the digest algorithm as a bare string in several places when verifying signatures.
The override spread it,
{ ...algorithm }, which turns a string into array; Web Crypto then rejects it. Any pkijs verification after this engine is installed, i.e. after any sign, failed that way.