build: clean stale versioned libraries in genclean#4188
Open
grandixximo wants to merge 1 commit into
Open
Conversation
genclean removed only $(TARGETS), so a leftover ../lib/*.so.N from a prior build (e.g. a soname left behind when switching branches in a RIP tree) survived make clean. Glob the versioned libraries so make clean removes them too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the
gencleanpart of #4180 to 2.9.gencleanremoved only$(TARGETS), so a leftover../lib/*.so.Nfrom a prior build (for example a soname left behind when switching branches in a RIP tree, sinceliblinuxcnciniis.so.0in 2.9 and.so.1in 2.10) survivedmake clean. Glob the versioned libraries somake cleanremoves them too.