Skip to content

fix(deps): fix legacy nvenc presets and bump third-party/build-deps - #5668

Merged
ReenigneArcher merged 4 commits into
masterfrom
fix/FFmpeg-9
Sep 10, 2026
Merged

fix(deps): fix legacy nvenc presets and bump third-party/build-deps#5668
ReenigneArcher merged 4 commits into
masterfrom
fix/FFmpeg-9

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Sep 10, 2026

Copy link
Copy Markdown
Member

Description

Fixes legacy nvenc presets, renames aq config option to spacial_aq. Bumps third-party/build-deps repo with patches for dynamic nv codec sdk selection on Linux, and Vulkan fixes.

Additionally, x264 is compiled with PIC fixing a compile issue in #4987

TODO:

  • confirm fixes work
  • make build-deps release "latest"

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review September 10, 2026 01:30
@ReenigneArcher
ReenigneArcher marked this pull request as draft September 10, 2026 01:30
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.53%. Comparing base (4ffca95) to head (30f7386).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/video.cpp 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5668      +/-   ##
==========================================
+ Coverage   37.52%   37.53%   +0.01%     
==========================================
  Files         104      104              
  Lines       26016    26023       +7     
  Branches    11482    11485       +3     
==========================================
+ Hits         9762     9769       +7     
+ Misses      15165    13397    -1768     
- Partials     1089     2857    +1768     
Flag Coverage Δ
Archlinux 21.09% <80.00%> (+<0.01%) ⬆️
FreeBSD-amd64 23.40% <66.66%> (+0.03%) ⬆️
Homebrew-macos-14 36.53% <100.00%> (+0.02%) ⬆️
Homebrew-macos-15 37.08% <100.00%> (+0.01%) ⬆️
Homebrew-macos-26 37.40% <100.00%> (+0.03%) ⬆️
Homebrew-ubuntu-24.04 24.39% <100.00%> (+<0.01%) ⬆️
Linux-AppImage-aarch64 25.70% <100.00%> (+0.04%) ⬆️
Linux-AppImage-x86_64 25.89% <100.00%> (+0.01%) ⬆️
Windows-AMD64 30.21% <100.00%> (+0.03%) ⬆️
Windows-ARM64 25.36% <85.71%> (+0.02%) ⬆️
macOS-arm64 30.75% <100.00%> (+0.01%) ⬆️
macOS-x86_64 31.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.cpp 60.95% <100.00%> (+0.08%) ⬆️
src/config.h 18.75% <ø> (ø)
src/nvenc/nvenc_dynamic_factory.cpp 85.18% <100.00%> (+0.87%) ⬆️
src/nvenc/nvenc_version.h 100.00% <100.00%> (ø)
src/video.cpp 54.63% <0.00%> (ø)

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffca95...30f7386. Read the comment docs.

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review September 10, 2026 14:43
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
13 New issues
E Maintainability Rating on New Code (required ≥ A)
13 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher ReenigneArcher mentioned this pull request Sep 10, 2026
2 tasks
@github-actions

Copy link
Copy Markdown
Last Updated 2026-09-10 15:54:19 UTC
Source Run CI Run #5443
Commit 30f7386997e43ef4327f95c5d44134052a4acf6a

Screenshot Comparison

PR #5668 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher merged commit f2c9f34 into master Sep 10, 2026
77 of 78 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/FFmpeg-9 branch September 10, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant