fix(build): prefer make over mingw32-make on non-Windows hosts - #765
Merged
ReenigneArcher merged 1 commit intoAug 30, 2026
Merged
Conversation
luanweslley77
marked this pull request as ready for review
August 29, 2026 14:08
ReenigneArcher
requested changes
Aug 30, 2026
find_program searched mingw32-make before make for every non-FreeBSD host. On Linux machines with the MinGW packages installed (a common setup for cross-building for Windows), mingw32-make is found first and the x264/FFmpeg install steps resolve their install paths into the MinGW sys-root, failing with permission errors. Keep mingw32-make first on Windows and prefer make/gmake elsewhere.
luanweslley77
force-pushed
the
fix/make-discovery-order
branch
from
August 30, 2026 09:40
94ed0ab to
16dc5bb
Compare
|
ReenigneArcher
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
find_program(MAKE_EXECUTABLE)searchesmingw32-makebeforemakefor every non-FreeBSD host. On Linux machines with the MinGW packages installed (a common setup for cross-building LizardByte projects for Windows),mingw32-makeis found first and the x264/FFmpeg install steps then resolve their install paths into the MinGW sys-root, failing with permission errors:This keeps
mingw32-makefirst on Windows and prefersmake/gmakeelsewhere. Validated on a Fedora host with/bin/mingw32-makeinstalled: configure now reportsFound make: /bin/makeand the full dependency build completes.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.