Skip to content

fix(toolbar): update bookmark menu arrows, icons, and fix scroll issue #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuietRobot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(toolbar): update bookmark menu arrows, icons, and fix scroll issue #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad97046
fix(toolbar): update bookmark menu arrows, icons, and fix scroll issue
QuietRobot Aug 27, 2026
b76c53b
Merge branch 'main' into fix/bookmarks-toolbar-rework
QuietRobot Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion chrome/icons/arrow-filled-down.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions chrome/icons/arrow-filled-up.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
32 changes: 29 additions & 3 deletions chrome/icons/icons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1592,16 +1592,23 @@ menuitem[data-l10n-id="origin-controls-options"] .menu-text::after {
.menu-right {
opacity: 0 !important;
}

menu::after {
content: "";
margin-right: -1px !important;
content: "" !important;
margin-block: auto !important;
display: flex !important;
align-items: center !important;
margin-right: -6px !important;
color: var(--textSecondary) !important;
font-size: 10px !important;
opacity: 1 !important;
font-family: 'Segoe Fluent Icons', 'Segoe MDL2 Assets' !important;
background-size: 10px !important;
background-repeat: no-repeat !important;
background-position: center center !important;
background-image: none !important;
}

#protections-popup-mainView .subviewbutton-nav:not(.notFound),
.widget-overflow-list .subviewbutton-nav,
.PanelUI-subView .subviewbutton-nav {
Expand Down Expand Up @@ -1634,6 +1641,25 @@ menu::after {
background-image: url(caret-right.svg) !important;
}

/* Bookmarks toolbar scroll arrows */

#scrollbutton-up[part="scrollbutton-up"] {
background-image: var(--menu-arrow-icon-up, url(caret-left.svg)) !important;
background-repeat: no-repeat !important;
background-position: center center !important;
background-size: 8px !important;
}
#scrollbutton-down[part="scrollbutton-down"] {
background-image: var(--menu-arrow-icon-down, url(caret-right.svg)) !important;
background-repeat: no-repeat !important;
background-position: center center !important;
background-size: 8px !important;
}
.menupopup-arrowscrollbox {
--menu-arrow-icon-up: url(arrow-filled-up.svg);
--menu-arrow-icon-down: url(arrow-filled-down.svg);
}

/* Proper back icon inside panels */
.panel-header {
& > .subviewbutton-back {
Expand Down Expand Up @@ -2267,4 +2293,4 @@ img[srcset="chrome://browser/skin/qrcode.svg"] {

#share-tab-button {
list-style-image: url(share.svg) !important;
}
}
59 changes: 57 additions & 2 deletions chrome/userChrome.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4666,6 +4666,56 @@ menupopup menu[disabled="true"], menupopup menuitem[disabled="true"] {
}
}

/* ========== Bookmarks toolbar ========== */

#BMB_searchBookmarks,
#BMB_viewBookmarksSidebar {
position: relative !important;
}

* {
--menu-clip-enable: 0;
}

.menupopup-arrowscrollbox {
--menu-clip-enable: 1;
}

scrollbox[part="scrollbox"] {
--clr-top: 0px;
--clr-bottom: 0px;
clip-path: inset(var(--clr-top) 0 var(--clr-bottom) 0) !important;
padding-top: var(--clr-top) !important;
padding-bottom: var(--clr-bottom) !important;
}

toolbarbutton#scrollbutton-up:not([disabled]) ~ scrollbox[part="scrollbox"] {
--clr-top: calc(26px * var(--menu-clip-enable, 0));
}

scrollbox[part="scrollbox"]:has(~ toolbarbutton#scrollbutton-down:not([disabled])) {
--clr-bottom: calc(26px * var(--menu-clip-enable, 0));
}

.menupopup-arrowscrollbox {
--menu-scrollbtn-shift-x: 2px;
--menu-scrollbtn-shift-up-y: 10px;
--menu-scrollbtn-shift-down-y: 6px;
}

#scrollbutton-up[part="scrollbutton-up"] {
position: relative;
z-index: 2;
top: calc(-8px + var(--menu-scrollbtn-shift-up-y, 0px)) !important;
left: calc(4px + var(--menu-scrollbtn-shift-x, 0px)) !important;
}
#scrollbutton-down[part="scrollbutton-down"] {
position: relative;
z-index: 2;
top: calc(-8px + var(--menu-scrollbtn-shift-down-y, 0px)) !important;
left: calc(4px + var(--menu-scrollbtn-shift-x, 0px)) !important;
}

/* ========== Dialog boxes ========== */

dialog:not(#window-modal-dialog) {
Expand Down Expand Up @@ -8300,6 +8350,11 @@ tab-split-view-wrapper {
margin-bottom: 0 !important;
}

#tabbrowser-arrowscrollbox {
--menu-scrollbtn-shift-up-y: 1px;
--menu-scrollbtn-shift-down-y: 1px;
}

@media (-moz-platform: windows) and (not (-moz-windows-accent-color-in-titlebar)) {
:root[sizemode="normal"][customtitlebar]:not([inFullscreen]) #navigator-toolbox {
padding-top: 0 !important;
Expand Down Expand Up @@ -8743,7 +8798,7 @@ tab-split-view-wrapper {

/* Toolbar icons pinned to the tab area */
#TabsToolbar .toolbarbutton-1 {
margin-bottom: 6px !important;
margin-bottom: 5px !important;
}

/* Tab gap up and down */
Expand Down Expand Up @@ -11738,4 +11793,4 @@ tab-split-view-wrapper {
}
}
}
}
}