fix osdate field types to match Lua manual#3416
Open
letuanhai wants to merge 1 commit into
Open
Conversation
`osdate` (return type of `os.date()`) fields are all integers (not `integer|string`), except for `isdst` which is `boolean` and may be absent if the information is not available. The `integer|string` union belongs on `osdateparam` (used by `os.time()`), not the return type.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the type annotations for the osdate class in meta/template/os.lua by changing the fields year, month, day, hour, min, sec, wday, and yday from integer|string to integer, and making isdst optional (boolean?). There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osdate(return type ofos.date()) fields are all integers (notinteger|string), except forisdstwhich isbooleanand may be absent if the information is not available. Theinteger|stringunion belongs onosdateparam(used byos.time()), not the return type.