Skip to content

Remove copying binary history to star history - #1030

Merged
Debraheem merged 5 commits into
mainfrom
remove-copying
Jul 31, 2026
Merged

Remove copying binary history to star history#1030
Debraheem merged 5 commits into
mainfrom
remove-copying

Conversation

@matthiasfabry

Copy link
Copy Markdown
Contributor

I consider this a "legacy" setting due to how binary history needed to be plotted with pgstar.

I argue defaulting the copying/appending to false is a not-too-invasive change. Users will either need to reenable this in the inlists, or modify their data-analysis scripts that read in binary history data.

I also took the time to set up pgbinary use in the remaining (science) binary test_suite cases (creating a rough template for single star use in pgbinary).

Restored Orbit_txt_scale_factor to avoid breaking existing pgbinary inlists.
add pgstar to wind_fed_bhhmxb
make pgbinary title intent in only, preventing overwrite
@Debraheem

Copy link
Copy Markdown
Member

I think this branch can be merged after testing, however my concern is that users often do plot binary parameters in pgstars instead of pgbinary, and might not see this control in the future. Should we really default to off? I don't mind either way.

@matthiasfabry

Copy link
Copy Markdown
Contributor Author

I guess it comes down to opinion. I'm obviously very biased to using pgbinary over pgstar. I fact, I argue there's nothing pgbinary can't do that pgstar can (apart from plotting a binary column alongside a star column on the same history plot).

I feel changing the default is a good compromise between making MESA less bulky to the everyday and new user, and removing the capability altogether (which would break the power user's scripts and plots)

@Debraheem Debraheem added the release-blocker Things that should be fixed before the next release label Jul 29, 2026
@Debraheem

Copy link
Copy Markdown
Member

passes testing, https://testhub.mesastar.org/remove-copying/commits/head can i merge?

@Debraheem
Debraheem merged commit d5a947a into main Jul 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-blocker Things that should be fixed before the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants