Skip to content

fix(dfns): fix olf idcxs fk backfill, trim migration comments #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpbonelli merged 3 commits into from
Aug 22, 2026
Merged

fix(dfns): fix olf idcxs fk backfill, trim migration comments #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bef346
fix(dfns): olf-zdg/olf-dfw idcxs fk backfill targets nonexistent olf-cxs
wpbonelli Aug 22, 2026
f3e781f
clean up comments
wpbonelli Aug 22, 2026
081ddeb
update snapshots
wpbonelli Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/olf-dfw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"optional": true,
"dtype": "integer",
"index": true,
"fk": "olf-cxs.packagedata.idcxs",
"fk": "chf-cxs.packagedata.idcxs",
"shape": [
"nodes"
]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/olf-dfw.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ description = "integer value indication the cross section identifier in the Cros
optional = true
dtype = "integer"
index = true
fk = "olf-cxs.packagedata.idcxs"
fk = "chf-cxs.packagedata.idcxs"
shape = [
"nodes",
]
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/olf-dfw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,6 @@ blocks:
optional: true
dtype: integer
index: true
fk: olf-cxs.packagedata.idcxs
fk: chf-cxs.packagedata.idcxs
shape:
- nodes
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/olf-zdg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"description": "is the identifier for the cross section specified in the CXS Package. A value of zero indicates the zero-depth-gradient calculation will use parameters for a hydraulically wide channel.",
"tagged": false,
"index": true,
"fk": "olf-cxs.packagedata.idcxs"
"fk": "chf-cxs.packagedata.idcxs"
},
"width": {
"type": "double",
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/olf-zdg.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ longname = "cross section identifier"
description = "is the identifier for the cross section specified in the CXS Package. A value of zero indicates the zero-depth-gradient calculation will use parameters for a hydraulically wide channel."
tagged = false
index = true
fk = "olf-cxs.packagedata.idcxs"
fk = "chf-cxs.packagedata.idcxs"

[blocks.period.fields.stress_period_data.item.fields.width]
type = "double"
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/olf-zdg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ blocks:
wide channel.
tagged: false
index: true
fk: olf-cxs.packagedata.idcxs
fk: chf-cxs.packagedata.idcxs
width:
type: double
longname: width of the zero-depth gradient boundary
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/swf-dfw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
"optional": true,
"dtype": "integer",
"index": true,
"fk": "swf-cxs.packagedata.idcxs",
"shape": [
"nodes"
]
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/swf-dfw.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ description = "integer value indication the cross section identifier in the Cros
optional = true
dtype = "integer"
index = true
fk = "swf-cxs.packagedata.idcxs"
shape = [
"nodes",
]
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/swf-dfw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,5 @@ blocks:
optional: true
dtype: integer
index: true
fk: swf-cxs.packagedata.idcxs
shape:
- nodes
3 changes: 1 addition & 2 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/swf-zdg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@
"longname": "cross section identifier",
"description": "is the identifier for the cross section specified in the CXS Package. A value of zero indicates the zero-depth-gradient calculation will use parameters for a hydraulically wide channel.",
"tagged": false,
"index": true,
"fk": "swf-cxs.packagedata.idcxs"
"index": true
},
"width": {
"type": "double",
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/swf-zdg.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ longname = "cross section identifier"
description = "is the identifier for the cross section specified in the CXS Package. A value of zero indicates the zero-depth-gradient calculation will use parameters for a hydraulically wide channel."
tagged = false
index = true
fk = "swf-cxs.packagedata.idcxs"

[blocks.period.fields.stress_period_data.item.fields.width]
type = "double"
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/swf-zdg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ blocks:
wide channel.
tagged: false
index: true
fk: swf-cxs.packagedata.idcxs
width:
type: double
longname: width of the zero-depth gradient boundary
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/olf-dfw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"optional": true,
"dtype": "integer",
"index": true,
"fk": "olf-cxs.packagedata.idcxs",
"fk": "chf-cxs.packagedata.idcxs",
"shape": [
"nodes"
]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/olf-dfw.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ description = "integer value indication the cross section identifier in the Cros
optional = true
dtype = "integer"
index = true
fk = "olf-cxs.packagedata.idcxs"
fk = "chf-cxs.packagedata.idcxs"
shape = [
"nodes",
]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/olf-dfw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ blocks:
optional: true
dtype: integer
index: true
fk: olf-cxs.packagedata.idcxs
fk: chf-cxs.packagedata.idcxs
shape:
- nodes
memory:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/olf-zdg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"description": "is the identifier for the cross section specified in the CXS Package. A value of zero indicates the zero-depth-gradient calculation will use parameters for a hydraulically wide channel.",
"tagged": false,
"index": true,
"fk": "olf-cxs.packagedata.idcxs"
"fk": "chf-cxs.packagedata.idcxs"
},
"width": {
"type": "double",
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/olf-zdg.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ longname = "cross section identifier"
description = "is the identifier for the cross section specified in the CXS Package. A value of zero indicates the zero-depth-gradient calculation will use parameters for a hydraulically wide channel."
tagged = false
index = true
fk = "olf-cxs.packagedata.idcxs"
fk = "chf-cxs.packagedata.idcxs"

[blocks.period.fields.stress_period_data.item.fields.width]
type = "double"
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/olf-zdg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ blocks:
wide channel.
tagged: false
index: true
fk: olf-cxs.packagedata.idcxs
fk: chf-cxs.packagedata.idcxs
width:
type: double
longname: width of the zero-depth gradient boundary
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/swf-dfw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@
"optional": true,
"dtype": "integer",
"index": true,
"fk": "swf-cxs.packagedata.idcxs",
"shape": [
"nodes"
]
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/swf-dfw.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ description = "integer value indication the cross section identifier in the Cros
optional = true
dtype = "integer"
index = true
fk = "swf-cxs.packagedata.idcxs"
shape = [
"nodes",
]
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/swf-dfw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ blocks:
optional: true
dtype: integer
index: true
fk: swf-cxs.packagedata.idcxs
shape:
- nodes
memory:
Expand Down
3 changes: 1 addition & 2 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/swf-zdg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,7 @@
"longname": "cross section identifier",
"description": "is the identifier for the cross section specified in the CXS Package. A value of zero indicates the zero-depth-gradient calculation will use parameters for a hydraulically wide channel.",
"tagged": false,
"index": true,
"fk": "swf-cxs.packagedata.idcxs"
"index": true
},
"width": {
"type": "double",
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/swf-zdg.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ longname = "cross section identifier"
description = "is the identifier for the cross section specified in the CXS Package. A value of zero indicates the zero-depth-gradient calculation will use parameters for a hydraulically wide channel."
tagged = false
index = true
fk = "swf-cxs.packagedata.idcxs"

[blocks.period.fields.stress_period_data.item.fields.width]
type = "double"
Expand Down
1 change: 0 additions & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/swf-zdg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ blocks:
wide channel.
tagged: false
index: true
fk: swf-cxs.packagedata.idcxs
width:
type: double
longname: width of the zero-depth gradient boundary
Expand Down
Loading
Loading