Conversation
Nothing reads them after the web change. `investigation_lens_runs` goes, along with `investigations.fanout_*`, `plan_json`, `planner_*`, `validator_*` and `workflow_instance_id` (0058, which also removes the lane table from the Electric publication). `InvestigationDocument` and the v2 resource lose `lens_runs`, `validator` and `fanout`; the service stops loading lanes, the stale sweep has one budget, the pass count is the run count, and the Electric proxy drops the lane shape. The migration test that replays 0035 now does so at its own point in history: a later migration may legitimately drop what an earlier one added, and what has to hold is that a half-applied branch converged at the time.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (26)
💤 Files with no reviewable changes (9)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change removes fan-out and lens-run data from investigation contracts, database persistence, backend processing, Electric synchronization, API responses, and web mappings. Stale handling and quota accounting now use single-investigation rules. ChangesSingle-Agent Investigation Model
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~60 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The single-agent investigation model is consistently reflected across the provided contracts, persistence, backend flow, and synchronization shapes. No actionable issue remains before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Stack 4 of 4 — based on the web PR. Drops what the fan-out stored.
What changes
investigation_lens_runsis dropped, along withinvestigations.fanout_*,plan_json,planner_*,validator_*andworkflow_instance_id(migration0058_drop_investigation_lanes, which also removes the lane table from the Electric publication).InvestigationDocumentand the v2Investigationresource loselens_runs,validatorandfanout. Both were documented as evolving shapes; nothing in the web app or the iOS app reads them after the previous PR.InvestigationServiceno longer loads lanes; the stale sweep has one 15-minute budget; the pass count is the run count; the diagnosis writers drop the fan-out bookkeeping.Deploy note
Prod migrations are applied by hand.
0058drops a table and ten columns; nothing reads them after PRs 1–3 are deployed, so apply it after those are live.Verified
Typechecks on
packages/domain,packages/backend,apps/api,apps/ai,apps/web,apps/electric-sync; vitest for the migration journal (the idempotent-replay test now replays0035at its own point in history), the investigation service and enqueue paths, the electric shapes, the v2 investigation routes and the web collection mapper.db:generatereports no further schema changes.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit