Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to a theme rule, is covered by a targeted test assertion, and the bundled outputs reflect the same update.
Pull request overview
This PR addresses an issue in the hidden-syntax rendering mode where enabling font ligatures can lead to a non-zero bounding rect for syntax that should be visually “zero-sized”, by explicitly disabling ligatures on hidden-syntax source spans.
Changes:
- Disable ligatures for
.cm-md-syntaxHiddenSource(and its descendants) viafont-variant-ligatures: none !important. - Extend the existing hidden-syntax theme test to assert the generated CSS includes the new ligature rule (value +
!importantpriority). - Update built
dist/bundles to include the theme change.
File summaries
| File | Description |
|---|---|
| tests/hiddenSyntax.test.ts | Adds assertions verifying the baseTheme CSS disables ligatures with !important. |
| src/hiddenSyntax/theme.ts | Disables ligatures for hidden syntax source spans to avoid non-zero geometry. |
| dist/markedit-preview.js | Rebuilt bundle reflecting the theme change. |
| dist/lite/markedit-preview.js | Rebuilt lite bundle reflecting the theme change. |
Review details
- Files reviewed: 2/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.