Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new vertical-motion logic uses range.assoc || 1, which incorrectly overrides a valid assoc = 0 and can produce incorrect coordinate/selection behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR introduces a custom “ArrowUp / Shift-ArrowUp” vertical movement command for the hidden-syntax editor mode to correct cases where CodeMirror vertical motion skips over an ATX heading line, and adds targeted tests to lock in the expected behavior.
Changes:
- Added
cursorLineUp/selectLineUpcommands plus acorrectedLineUpkeymap extension to adjust upward motion when an ATX heading is skipped. - Registered the new keymap in the hidden-syntax base extension so it applies when
hiddenSyntaxExtensionis enabled. - Added a new “Vertical motion” test suite covering correction behavior, selection-extension semantics, multi-selection fallback behavior, and precedence with higher-priority keymaps.
File summaries
| File | Description |
|---|---|
| tests/hiddenSyntax.test.ts | Adds a “Vertical motion” test suite validating corrected ArrowUp/Shift-ArrowUp behavior and precedence rules. |
| src/hiddenSyntax/selection.ts | Implements corrected upward vertical motion commands and exports a Prec.high keymap extension. |
| src/hiddenSyntax/index.ts | Wires the new corrected ArrowUp keymap into the hidden-syntax base extension. |
Review details
- Files reviewed: 3/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.