Skip to content

Potential fix for code scanning alert no. 12: Uncontrolled command line #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrzt721010 merged 1 commit into from
Sep 2, 2026
Merged

Potential fix for code scanning alert no. 12: Uncontrolled command line #732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions web/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@
if not os.path.exists(PYTHON_EXE):
PYTHON_EXE = sys.executable

ALLOWED_LIST_FILES = {
"http.txt",
"socks4.txt",
"socks5.txt",
"proxies.txt",
"reflectors.txt",
}

app = Flask(
__name__,
template_folder=str(BASE_DIR / "web" / "templates"),
Expand Down Expand Up @@ -257,22 +265,22 @@ def start_attack():
if socks_type not in VALID_SOCKS_TYPES:
socks_type = 0
rpc = _safe_int(data.get("rpc", 10), 10, 1, 10000)
proxylist = data.get("proxylist", "http.txt").strip() or "http.txt"
if not re.match(r'^[\w\-. ]+\.txt$', proxylist):
proxylist = Path(data.get("proxylist", "http.txt").strip() or "http.txt").name
if proxylist not in ALLOWED_LIST_FILES:
proxylist = "http.txt"
cmd.extend([str(socks_type), str(threads), proxylist, str(rpc), str(duration)])
else:
cmd.extend([str(threads), str(duration)])
if method in METHODS_AMP:
amp_file = data.get("reflector", "").strip()
if amp_file and re.match(r'^[\w\-. ]+\.txt$', amp_file):
amp_file = Path(data.get("reflector", "").strip()).name
if amp_file in ALLOWED_LIST_FILES:
cmd.append(amp_file)
else:
proxy_type = _safe_int(data.get("socks_type", 0), 0, 0, 6)
if proxy_type not in VALID_SOCKS_TYPES:
proxy_type = 0
proxy_file = data.get("proxylist", "").strip()
if proxy_file and re.match(r'^[\w\-. ]+\.txt$', proxy_file):
proxy_file = Path(data.get("proxylist", "").strip()).name
if proxy_file in ALLOWED_LIST_FILES:
cmd.extend([str(proxy_type), proxy_file])

task_id = str(uuid.uuid4())[:8]
Expand Down
Loading