fix(menu): right-click on a link shows the menu; every row has an icon (#95) - #96
Merged
Merged
Conversation
xterm's web-links addon activates on a click of any button. Only a left click opens now, and the menu offers Open link beside Copy link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Maxaubert
changed the title
# Conflicts: # core/package.json # package-lock.json # package.json
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
#95) (#96) * fix(links): a right-click on a link opens the menu, not the link (#95) xterm's web-links addon activates on a click of any button. Only a left click opens now, and the menu offers Open link beside Copy link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t * feat(menu): a glyph on every menu row, as in Prism's Explorer (#95) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95.
A right-click on a link opened the link and showed the menu at the same time. xterm's web-links addon activates on a click of any button.
FileMenuIconpaths and style; find, help and close are drawn to match.Core change, so Prism gets it too through the automatic bump. The menu rows are this app's own; Prism's own right-click menu is unchanged. Core 0.16.1, app 0.19.1. These numbers overlap with the other open PRs, and whichever merges later gets bumped again.
Verified:
selectionEdite2e now asserts three things. A right-click on a link opens nothing. The menu reads Copy link, Open link. Open link opens it, and a left click still does. This failed on main (the link opened on the right-click, and there was no Open link row)..e2e-shots/term-menu-link.pngwas checked by eye.lastTabincluded this time.🤖 Generated with Claude Code
https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t