feat(keybinds): allow Ctrl+wheel as the wheel-zoom bind (#295) - #296
Merged
Merged
Conversation
Wind swallows the notch, so Ctrl+wheel zooms the screen instead of the page. Shift+wheel and Ctrl+click stay refused. Version 0.13.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #295.
Owner decision: Ctrl+wheel is an acceptable wheel-zoom bind. Wind swallows the notch, so it zooms the screen instead of the browser or app page. Shift+wheel (horizontal scroll) and Ctrl+click (multi-select) stay refused; the click rule is now its own function instead of reusing the wheel's.
src/keybind_rules.handui/src/lib/keybindRules.js; the shared fixture now expectswheel 1 ok.Tests: 360 unit, 70 Playwright (new assertion: Ctrl+wheel binds as
Ctrl+Wheel).Live check on the owner's PC was inconclusive: the app received no wheel events under Ctrl+wheel, but the zoom-level readings were disturbed because the screen was already being zoomed when the check ran.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG