Skip to content

fix: skip unresolved skill memory updates#2021

Draft
RerankerGuo wants to merge 1 commit into
MemTensor:mainfrom
RerankerGuo:fix/skip-unresolved-skill-updates
Draft

fix: skip unresolved skill memory updates#2021
RerankerGuo wants to merge 1 commit into
MemTensor:mainfrom
RerankerGuo:fix/skip-unresolved-skill-updates

Conversation

@RerankerGuo

Copy link
Copy Markdown

Summary

  • Fixes fix: dont create skill everytime #1769.
  • Skip skill-memory updates whose old_memory_id cannot be resolved from recalled existing skills.
  • Add a regression test for unresolved update filtering.

Validation

  • python3 -m py_compile src/memos/mem_reader/read_skill_memory/process_skill_memory.py tests/mem_reader/test_skill_memory.py
  • python3 -m pytest tests/mem_reader/test_skill_memory.py -q (blocked: No module named pytest)
  • make format (blocked: poetry: Command not found)

@Memtensor-AI Memtensor-AI changed the base branch from main to dev-v2.0.22 July 2, 2026 02:23
@Memtensor-AI

Copy link
Copy Markdown
Collaborator

Automated Test Results: PASSED

Cloud test-engine full-audit rerun against dev-v2.0.22 completed successfully after clearing the cloud workspace disk.

  • Run: tr-40071e1e-0f1 on cloud test-engine 10010
  • memos_python_core/changed-repo-python: 3 passed, 0 failed, 0 skipped

Manual code review is still required before merge.

@CarltonXiang CarltonXiang deleted the branch MemTensor:main July 3, 2026 07:25
@syzsunshine219 syzsunshine219 reopened this Jul 3, 2026
@syzsunshine219 syzsunshine219 added the needs-audit Requires manual audit before merge label Jul 3, 2026
@syzsunshine219 syzsunshine219 changed the base branch from dev-v2.0.22 to main July 3, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-audit Requires manual audit before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: dont create skill everytime

4 participants