Skip to content

fix(profile-metrics-controller): tag, canonicalize, and dedupe hardware, imported, and non-mnemonic snap accounts #10107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathieuartu wants to merge 2 commits into
base: main
Choose a base branch
from
+667 −188
Open

fix(profile-metrics-controller): tag, canonicalize, and dedupe hardware, imported, and non-mnemonic snap accounts #10107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f311866
fix(profile-metrics-controller): tag, canonicalize, and dedupe hardwa…
mathieuartu Sep 4, 2026
13f68d5
fix: update CHANGELOG
mathieuartu Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/profile-metrics-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Tag hardware, imported-private-key, and non-mnemonic Snap accounts with a `source` on `AccountWithScopes` when submitting profile metrics ([#10107](https://github.com/MetaMask/core/pull/10107))
- The value (`'hardware' | 'imported' | 'snap'`) is derived from `metadata.keyring.type`; mnemonic-backed accounts carry no source.
- Adds a `reportedAccounts` state property recording the canonical addresses that have been submitted, so enqueuing them again is a no-op.
- Re-enqueues all known accounts on the first unlock after upgrading so previously-synced records get a source and canonical address, gated by a new `accountSourceBackfillEnqueued` state flag (fresh installs flip the flag on their initial sync).

### Changed

- Canonicalize account addresses when they are enqueued rather than only when a proof of ownership is signed, so accounts without a proof (hardware, imported, non-mnemonic Snap) are also submitted in canonical form ([#10107](https://github.com/MetaMask/core/pull/10107))
- Bump `@metamask/transaction-controller` from `^69.4.0` to `^69.8.0` ([#9780](https://github.com/MetaMask/core/pull/9780), [#10080](https://github.com/MetaMask/core/pull/10080), [#9798](https://github.com/MetaMask/core/pull/9798), [#9823](https://github.com/MetaMask/core/pull/9823), [#9960](https://github.com/MetaMask/core/pull/9960), [#9969](https://github.com/MetaMask/core/pull/9969), [#10046](https://github.com/MetaMask/core/pull/10046))
- Bump `@metamask/superstruct` from `^3.1.0` to `^3.4.1` ([#9754](https://github.com/MetaMask/core/pull/9754))
- Bump `@metamask/accounts-controller` from `^39.0.6` to `^39.1.1` ([#9791](https://github.com/MetaMask/core/pull/9791), [#9807](https://github.com/MetaMask/core/pull/9807), [#9969](https://github.com/MetaMask/core/pull/9969))
Expand Down
Loading
Loading