refactor(bitcoin-wallet-snap): convert enums to as const objects - #216
Merged
Conversation
ulissesferreira
force-pushed
the
refactor/ban-enums-bitcoin
branch
from
August 27, 2026 09:26
3ee47ba to
64e6c7a
Compare
ulissesferreira
changed the title
ulissesferreira
changed the title
as const objects
ulissesferreira
changed the title
as const objectsas const objects
ulissesferreira
force-pushed
the
refactor/ban-enums-bitcoin
branch
from
August 27, 2026 09:32
64e6c7a to
4409b99
Compare
ulissesferreira
marked this pull request as ready for review
August 27, 2026 09:34
ulissesferreira
force-pushed
the
refactor/ban-enums-bitcoin
branch
from
August 27, 2026 09:34
4409b99 to
0d27834
Compare
Convert locally-declared TypeScript enums to `as const` objects with derived union types. BREAKING: Type signatures change - Enum is now a union of string/number literals instead of a nominal enum type. Runtime member access is unchanged.
ulissesferreira
force-pushed
the
refactor/ban-enums-bitcoin
branch
from
August 27, 2026 10:08
0d27834 to
bc25772
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert locally-declared TypeScript enums in bitcoin-wallet-snap to
as constobjects with derived union types.Refs: MetaMask/utils#280, MetaMask/eslint-config#417
Enums converted
CronjobMethod,Slip44,Purpose,Sep43ErrorCode,Fiat,CurrencyUnit,AccountFeature,AddressType,BalanceChangeType,ConfirmationStatus,TransactionTypeBreaking changes
Enumis now a union of string/number literals instead of a nominal enum typeEnum.Member) works the same wayValidation
tsc --noEmitpasses (only pre-existing baseline errors)enumdeclarations remaining in bitcoin-wallet-snapNote
The ESLint ban +
create-packagescript conversion previously in this branch have moved to a dedicated infra PR: #219