refactor(stellar-wallet-snap): convert enums to as const objects - #227
Open
ulissesferreira wants to merge 2 commits into
Open
refactor(stellar-wallet-snap): convert enums to as const objects#227ulissesferreira wants to merge 2 commits into
as const objects#227ulissesferreira wants to merge 2 commits into
Conversation
ulissesferreira
changed the title
… objects Convert all locally-declared enums to const objects with derived union types, matching the Bitcoin/Solana/Tron enum migration pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
ulissesferreira
force-pushed
the
refactor/ban-enums-stellar
branch
from
August 28, 2026 10:05
f2a5826 to
521475b
Compare
ulissesferreira
enabled auto-merge
August 28, 2026 11:06
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
ulissesferreira
changed the title
as const objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert locally-declared TypeScript enums in
stellar-wallet-snaptoas constobjects with derived union types.Refs: MetaMask/utils#280, MetaMask/eslint-config#417
Enums converted
typeofwhile preserving runtime member access and values.Validation
baseUrldeprecation warningpackages/stellar-wallet-snap/src: 0git diff --check: cleanNotes
No global lint configuration or changes outside
stellar-wallet-snapare included; those belong in the separate infrastructure change.