Skip to content

feat(solana-wallet-snap): use shareable serialization in Solana snap - #230

Merged
Julink-eth merged 6 commits into
mainfrom
feat/WPN-1943-use-shared-serialization-in-solana-snap
Aug 28, 2026
Merged

feat(solana-wallet-snap): use shareable serialization in Solana snap#230
Julink-eth merged 6 commits into
mainfrom
feat/WPN-1943-use-shared-serialization-in-solana-snap

Conversation

@Julink-eth

Copy link
Copy Markdown
Contributor

Explanation

  • Switch the Solana snap from local serialize / deserialize / Serializable to the shared helpers in @metamask/snap-networks-utils (WPN-1943).
  • Delete packages/solana-wallet-snap/src/core/serialization/ and rewire every call site (state, interface context, cache, clients, confirmation UI) to the shared package.
  • Cast serialize() results to Record<string, Json> at the three snap-API call sites that require an object (snap_createInterface, snap_updateInterface, snap_manageState). The shared helper is typed as Json; those values are always objects.
  • Drop unused eslint-suppressions.json entries that pointed at the deleted local serialization files.
  • No changelog entry: this is an internal rewire with no consumer-facing API change.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@Julink-eth
Julink-eth requested review from a team as code owners August 28, 2026 10:01
@Julink-eth
Julink-eth deployed to default-branch August 28, 2026 10:02 — with GitHub Actions Active
@Julink-eth

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/bitcoin-wallet-snap@2.0.1-preview-ddcf023f
@metamask-previews/snap-networks-utils@1.0.0-preview-ddcf023f
@metamask-previews/solana-wallet-snap@6.0.0-preview-ddcf023f
@metamask-previews/stellar-wallet-snap@0.1.0-preview-ddcf023f
@metamask-previews/tron-wallet-snap@3.1.0-preview-ddcf023f

@Julink-eth
Julink-eth added this pull request to the merge queue Aug 28, 2026
Merged via the queue into main with commit fbf6fbc Aug 28, 2026
53 checks passed
@Julink-eth
Julink-eth deleted the feat/WPN-1943-use-shared-serialization-in-solana-snap branch August 28, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants