Skip to content

feat(stellar-wallet-snap): use shareable serialization in Stellar snap - #235

Open
Julink-eth wants to merge 2 commits into
mainfrom
feat/WPN-1945-use-shared-serialization-in-stellar-snap
Open

feat(stellar-wallet-snap): use shareable serialization in Stellar snap#235
Julink-eth wants to merge 2 commits into
mainfrom
feat/WPN-1945-use-shared-serialization-in-stellar-snap

Conversation

@Julink-eth

Copy link
Copy Markdown
Contributor

Explanation

  • Switch the Stellar snap from local serialize / deserialize / Serializable to the shared helpers in @metamask/snap-networks-utils.
  • Rewire every call site (snap state, cache, prices, network service) to the shared package.
  • Keep serializeToString in src/utils/serialization.ts. It is Stellar-only (request/response logging in BaseHandler) and now wraps the shared serialize. Drop the duplicated serialize/deserialize unit tests; the shared package already covers them. One serializeToString test remains.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@Julink-eth
Julink-eth requested a review from a team as a code owner August 28, 2026 14:08
@Julink-eth
Julink-eth deployed to default-branch August 28, 2026 14:08 — with GitHub Actions Active
@Julink-eth

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/bitcoin-wallet-snap@2.0.1-preview-e53aa00
@metamask-previews/snap-networks-utils@1.0.0-preview-e53aa00
@metamask-previews/solana-wallet-snap@6.0.0-preview-e53aa00
@metamask-previews/stellar-wallet-snap@0.1.0-preview-e53aa00
@metamask-previews/tron-wallet-snap@3.1.0-preview-e53aa00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant