Conversation
An uncaught throw in the extension already reaches Sentry, because `Sentry.init` never sets `defaultIntegrations: false` and the browser SDK merges `globalHandlersIntegration` in. So a catch that only logs deletes the sole report rather than softening a crash. `tsc-blindspots` keeps its own passage and gains a pointer. Its description is trimmed to 1024 characters, which the repo lints and which #158's sweep missed because #167 landed three days earlier.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
observability/knowledge/error-reporting-paths.md.Sentry.initinsetupSentry.tsnever setsdefaultIntegrations: false, so the browser SDK mergesglobalHandlersIntegration()in and an uncaught throw or unhandled rejection already reports. A.catch(console.debug)on such a path deletes the only report rather than degrading gracefully, so the pair is reported versus silent rather than crash versus degrade.instrumentation's extension overlay pointing at it, since that skill is where what-reaches-Sentry already lives.tsc-blindspotskeeps its own "Silent failure modes deserve their own pass" passage and gains one line naming the prior question, which is whether the path reported at all. The knowledge file carries that passage's weighting rule as well, so an observability reader gets it without following a cross-domain link.tsc-blindspots' description from 1341 characters to under the 1024 the repo lints. It is the only skill onmaincurrently over budget: fix: shorten skill descriptions over the 1024-character operator limit #158's sweep merged three days after feat: Addstypescriptdomain with authoring, migration skills #167 introduced it, and CI lints changed files only, so it stayed dormant until this PR touched the file.Test plan
node --test test/*.test.mjspasses 72 of 72, up from 71 as the new knowledge file is collected.node .github/scripts/lint-skill-entry.mjson both touched skills reports 0 errors. Two warnings for a missing recommended section are pre-existing.skill.mdunderdomains/is within the description budget after this change.