Repository navigation
Add a dedicated long editor - #6691
Merged
Big-Iron-Cheems merged 1 commit intoOct 7, 2026
Merged
Big-Iron-Cheems merged 1 commit into
Big-Iron-Cheems merged 1 commit into
Conversation
Frko5000
approved these changes
Oct 6, 2026
Frko5000
left a comment
Contributor
There was a problem hiding this comment.
i might be missing something
MukjepScarlet
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
LongSettingcurrently uses a raw text box, with its input handling embedded inDefaultSettingsWidgetFactory.This adds a dedicated
WLongEdit, exposes it throughGuiTheme.longEdit(...), and uses it for long settings. The editor handles parsing, range validation and invalid-input rollback while preserving full 64-bit precision.Related issues
Follow-up to #6651.
How Has This Been Tested?
./gradlew buildwith Java 25.LongSetting, covering signed-long limits, values above2^53, min/max validation, overflow, invalid-input rollback, Enter/focus-loss callbacks and reset.Checklist: