Skip to content

vfs/shell: remote unlink should report and handle errors - #5159

Open
tuffnatty wants to merge 1 commit into
MidnightCommander:masterfrom
tuffnatty:fish-unlink-reports-errors
Open

tuffnatty wants to merge 1 commit into
MidnightCommander:masterfrom
tuffnatty:fish-unlink-reports-errors

Conversation

@tuffnatty

@tuffnatty tuffnatty commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Drop -f option from rm invocation. Otherwise, an attempt to delete files in a write-protected remote location reports no error and keeps the files. It's a problem c313396 tried to solve but apparently didn't succeed.

I would have added a test but I'll wait till (if) #5157 with the test infrastructure is merged in.

Checklist

  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works

(something c313396 tried to solve but apparently didn't succeed)

Signed-off-by: Phil Krylov <phil@krylov.eu>
@github-actions github-actions Bot added this to the Future Releases milestone Sep 18, 2026
@github-actions github-actions Bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Sep 18, 2026
@tuffnatty

Copy link
Copy Markdown
Contributor Author

Found and linked the erroneously closed issue #1501.

@zyv zyv added area: vfs Virtual File System support and removed needs triage Needs triage by maintainers labels Sep 18, 2026
@zyv zyv modified the milestones: Future Releases, 4.9.0 Sep 18, 2026

@zyv zyv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. I didn't test it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: vfs Virtual File System support prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

failure while deleting is not reported when working over fish

2 participants