Conversation
(something c313396 tried to solve but apparently didn't succeed) Signed-off-by: Phil Krylov <phil@krylov.eu>
Contributor
Author
|
Found and linked the erroneously closed issue #1501. |
zyv
approved these changes
Sep 18, 2026
zyv
left a comment
Member
There was a problem hiding this comment.
Looks reasonable to me. I didn't test it, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Drop
-foption fromrminvocation. Otherwise, an attempt to delete files in a write-protected remote location reports no error and keeps the files. It's a problem c313396 tried to solve but apparently didn't succeed.I would have added a test but I'll wait till (if) #5157 with the test infrastructure is merged in.
Checklist
git commit --amend -smake indent && make check)