Skip to content

Standardize release artifact naming conventions #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeGarde merged 1 commit into from
Jun 29, 2026
Merged

Standardize release artifact naming conventions #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/release-assets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,34 +35,39 @@ jobs:
- name: Linux arm64
runner: ubuntu-24.04-arm
target: aarch64-unknown-linux-gnu
asset_target: unknown-linux-gnu-aarch64
archive_ext: tar.gz
binary_name: commitbot
install_cmd: ""
linker: ""
- name: Linux x86_64
runner: ubuntu-24.04
target: x86_64-unknown-linux-gnu
asset_target: unknown-linux-gnu-x86_64
archive_ext: tar.gz
binary_name: commitbot
install_cmd: ""
linker: ""
- name: Amazon Linux / CentOS / RHEL arm64
runner: ubuntu-24.04-arm
target: aarch64-unknown-linux-musl
asset_target: unknown-linux-musl-aarch64
archive_ext: tar.gz
binary_name: commitbot
install_cmd: sudo apt-get update && sudo apt-get install -y musl-tools
linker: musl-gcc
- name: Amazon Linux / CentOS / RHEL x86_64
runner: ubuntu-24.04
target: x86_64-unknown-linux-musl
asset_target: unknown-linux-musl-x86_64
archive_ext: tar.gz
binary_name: commitbot
install_cmd: sudo apt-get update && sudo apt-get install -y musl-tools
linker: musl-gcc
- name: Windows x86_64
runner: ubuntu-24.04
target: x86_64-pc-windows-gnu
asset_target: pc-windows-gnu-x86_64
archive_ext: zip
binary_name: commitbot.exe
install_cmd: sudo apt-get update && sudo apt-get install -y mingw-w64
Expand Down Expand Up @@ -113,7 +118,7 @@ jobs:
shell: bash
run: |
set -euo pipefail
asset="commitbot-${{ steps.meta.outputs.tag }}-${{ matrix.target }}.tar.gz"
asset="commitbot-${{ steps.meta.outputs.tag }}-${{ matrix.asset_target }}.tar.gz"
tar -C "target/${{ matrix.target }}/release" -czf "$asset" "${{ matrix.binary_name }}"
echo "ASSET_PATH=$asset" >> "$GITHUB_ENV"

Expand All @@ -122,7 +127,7 @@ jobs:
shell: bash
run: |
set -euo pipefail
asset="commitbot-${{ steps.meta.outputs.tag }}-${{ matrix.target }}.zip"
asset="commitbot-${{ steps.meta.outputs.tag }}-${{ matrix.asset_target }}.zip"
cd "target/${{ matrix.target }}/release"
zip "../../../${asset}" "${{ matrix.binary_name }}"
cd -
Expand Down
4 changes: 2 additions & 2 deletions Taskfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,11 @@ tasks:
echo "Packaging into dist with version {{.VERSION}}..."

tar -C target/aarch64-apple-darwin/release \
-czf dist/commitbot-{{.VERSION}}-aarch64-apple-darwin.tar.gz \
-czf dist/commitbot-{{.VERSION}}-apple-darwin-aarch64.tar.gz \
commitbot

tar -C target/x86_64-apple-darwin/release \
-czf dist/commitbot-{{.VERSION}}-x86_64-apple-darwin.tar.gz \
-czf dist/commitbot-{{.VERSION}}-apple-darwin-x86_64.tar.gz \
commitbot

echo "Artifacts created:"
Expand Down
14 changes: 7 additions & 7 deletions devops/publish-if-complete.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ set -euo pipefail
TAG="${1:?usage: publish-if-complete.sh <tag>}"

EXPECTED=(
"commitbot-${TAG}-aarch64-apple-darwin.tar.gz"
"commitbot-${TAG}-x86_64-apple-darwin.tar.gz"
"commitbot-${TAG}-aarch64-unknown-linux-gnu.tar.gz"
"commitbot-${TAG}-x86_64-unknown-linux-gnu.tar.gz"
"commitbot-${TAG}-aarch64-unknown-linux-musl.tar.gz"
"commitbot-${TAG}-x86_64-unknown-linux-musl.tar.gz"
"commitbot-${TAG}-x86_64-pc-windows-gnu.zip"
"commitbot-${TAG}-apple-darwin-aarch64.tar.gz"
"commitbot-${TAG}-apple-darwin-x86_64.tar.gz"
"commitbot-${TAG}-unknown-linux-gnu-aarch64.tar.gz"
"commitbot-${TAG}-unknown-linux-gnu-x86_64.tar.gz"
"commitbot-${TAG}-unknown-linux-musl-aarch64.tar.gz"
"commitbot-${TAG}-unknown-linux-musl-x86_64.tar.gz"
"commitbot-${TAG}-pc-windows-gnu-x86_64.zip"
)

ACTUAL="$(gh release view "${TAG}" --json assets --jq '[.assets[].name]')"
Expand Down
8 changes: 4 additions & 4 deletions devops/render-release-notes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ cat <<EOF

| OS | arm64 | x86_64 |
| --- | --- | --- |
| macOS | [Download]($(asset_url "commitbot-${VERSION}-aarch64-apple-darwin.tar.gz")) | [Download]($(asset_url "commitbot-${VERSION}-x86_64-apple-darwin.tar.gz")) |
| Ubuntu* | [Download]($(asset_url "commitbot-${VERSION}-aarch64-unknown-linux-gnu.tar.gz")) | [Download]($(asset_url "commitbot-${VERSION}-x86_64-unknown-linux-gnu.tar.gz")) |
| RHEL** | [Download]($(asset_url "commitbot-${VERSION}-aarch64-unknown-linux-musl.tar.gz")) | [Download]($(asset_url "commitbot-${VERSION}-x86_64-unknown-linux-musl.tar.gz")) |
| Windows*** | — | [Download]($(asset_url "commitbot-${VERSION}-x86_64-pc-windows-gnu.zip")) |
| macOS | [Download]($(asset_url "commitbot-${VERSION}-apple-darwin-aarch64.tar.gz")) | [Download]($(asset_url "commitbot-${VERSION}-apple-darwin-x86_64.tar.gz")) |
| Ubuntu* | [Download]($(asset_url "commitbot-${VERSION}-unknown-linux-gnu-aarch64.tar.gz")) | [Download]($(asset_url "commitbot-${VERSION}-unknown-linux-gnu-x86_64.tar.gz")) |
| RHEL** | [Download]($(asset_url "commitbot-${VERSION}-unknown-linux-musl-aarch64.tar.gz")) | [Download]($(asset_url "commitbot-${VERSION}-unknown-linux-musl-x86_64.tar.gz")) |
| Windows*** | — | [Download]($(asset_url "commitbot-${VERSION}-pc-windows-gnu-x86_64.zip")) |

\* Ubuntu and compatible distributions like Debian, Mint, etc. that use glibc.
\** RHEL and compatible distributions like Amazon, Rocky, etc. that use musl instead of glibc.
Expand Down
Loading