Repository navigation
build(win-durable-ioring): pin the five path-only dependencies by version - #129
Merged
Merged
Conversation
…sion Completed item: DI-12.4: the five path-only dependencies of win-durable-ioring are pinned by version, keeping the path. publish-crate refused win-durable-ioring 0.1.0: cargo publish requires a version on every dependency, and durable-ioring, windows-ioring-sys, win-sync-sys, windows-threadpool-sys and win-time-sys had only a path. They are pinned at the releases the manifest and crates.io now carry. Typed as build, so it triggers no release of its own. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency requirements match the workspace versions, preserve local resolution, and introduce no runtime changes.
0 open findings
What changed in this PR
Adds the dependency versions needed to publish win-durable-ioring, while preserving local path resolution.
Changes:
- Adds version requirements to five path-only dependencies.
- Marks DI-12.4 complete and records the manual publication recovery process.
| File | Description |
|---|---|
| crates/win-durable-ioring/Cargo.toml | Adds five dependency version requirements. |
| crates/durable-ioring/COMPLETED-CHECKLIST.md | Archives DI-12.4 and publication recovery details. |
| crates/durable-ioring/CHECKLIST.md | Replaces DI-12.4 with a linked completion stub. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish-crate refused win-durable-ioring 0.1.0 because five dependencies had a path and no version (DI-12.4). They are pinned at the versions published or being published. A build commit, so it triggers no release. After merge, win-durable-ioring 0.1.0 is published by workflow_dispatch from main, since its tag points at the commit without the pins.