Repository navigation
docs(win-sync-sys): WS-1+.6 keeps the Release-As footer on a commit of this crate alone - #131
Merged
Merged
Conversation
…f this crate alone release-please applies the footer to every package a commit touches, so the earlier wording, which had the same change re-pin the dependents, would have requested 0.1.0 of windows-threadpool-sys, a downgrade. Found by review of PR 130. The dependents' requirements now move in a commit of their own. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only correction resolves the release-scoping concern, with only a minor link-formatting issue remaining.
1 open finding
What changed in this PR
Clarifies the release plan for win-sync-sys to prevent its version override from affecting dependent crates.
Changes:
- Restricts
Release-As: 0.1.0to a commit touching onlywin-sync-sys. - Separates dependent version updates, checking the release PR for automatic rewrites first.
| File | Description |
|---|---|
| crates/win-sync-sys/CHECKLIST.md | Clarifies release-footer scope and dependent update sequencing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Found by review of PR 131: the checklist named the file in inline code, where the repository's cross-reference rule wants a clickable relative link. Swept the item's other references: it names no other file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review finding on #130: a Release-As footer applies to every package the commit touches, so re-pinning the dependents in the same commit would request 0.1.0 of windows-threadpool-sys, a downgrade. WS-1+.6 now keeps the footer on a win-sync-sys-only commit and re-pins the dependents separately. Docs only.