Repository navigation
ci: run the all-features and default-features build + test in parallel - #132
Merged
Merged
Conversation
The two variants were steps of one job, built and tested one after the other. They share nothing but the checkout, so they are now a two-entry matrix; the default-feature variant also runs the UNC and windows-file-watcher steps, which exist to verify a default build. The ruleset requires a check named exactly build + test, which the matrix no longer produces, so an aggregate job of that name passes only when every variant did (always(), so a failed variant fails it rather than leaving it skipping). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Existing coverage is preserved, and the aggregate check rejects unsuccessful matrix results.
0 open findings
What changed in this PR
Parallelizes the workspace’s all-features and default-features CI runs while preserving coverage and the required check name.
Changes:
- Runs feature variants in parallel with separate cache keys.
- Keeps isolated tests in the default-features variant.
- Adds an aggregate
build + testcheck requiring both variants to succeed.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Introduces the feature matrix and aggregate required check. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two variants were steps of one job and ran back to back (about four and a half minutes of cargo on the last main run, in two near-equal halves). They are now a two-entry matrix of parallel jobs. The ruleset requires a check named exactly 'build + test', so an aggregate job keeps that name and passes only when every variant did. The UNC current-directory and windows-file-watcher default-feature steps move with the default variant. Rust-cache is keyed per variant. The new job names appear on this PR: 'build + test (all features)', 'build + test (default features)' and the aggregate 'build + test'.